Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resource definition using manifest URL #478

Merged

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jun 15, 2022

SUMMARY

Closes #451

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

k8s
k8s_scale
k8s_service

@softwarefactory-project-zuul
Copy link

Build failed.

✔️ build-ansible-collection SUCCESS in 3m 06s
ansible-test-sanity-docker-devel FAILURE in 8m 41s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 9m 06s (non-voting)
ansible-test-sanity-docker-stable-2.9 FAILURE in 12m 47s
ansible-test-sanity-docker-stable-2.11 FAILURE in 9m 08s
ansible-test-sanity-docker-stable-2.12 FAILURE in 9m 09s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 8m 08s
✔️ ansible-test-splitter SUCCESS in 2m 49s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 14m 38s (non-voting)
integration-kubernetes.core-devel-2 FAILURE in 15m 14s (non-voting)
✔️ integration-kubernetes.core-devel-3 SUCCESS in 24m 11s (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 13m 16s
integration-kubernetes.core-milestone-2 FAILURE in 15m 18s
✔️ integration-kubernetes.core-milestone-3 SUCCESS in 23m 47s
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 13m 17s
integration-kubernetes.core-2.9-2 FAILURE in 15m 17s
✔️ integration-kubernetes.core-2.9-3 SUCCESS in 24m 12s
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 13m 05s
integration-kubernetes.core-2.10-2 FAILURE in 15m 23s
✔️ integration-kubernetes.core-2.10-3 SUCCESS in 23m 58s
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 13m 36s
integration-kubernetes.core-with-turbo-2 FAILURE in 14m 50s
✔️ integration-kubernetes.core-with-turbo-3 SUCCESS in 23m 50s
ansible-tox-linters FAILURE in 4m 55s
✔️ ansible-galaxy-importer SUCCESS in 4m 27s

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ build-ansible-collection SUCCESS in 3m 04s
ansible-test-sanity-docker-devel FAILURE in 9m 56s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 9m 36s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 40s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 41s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 02s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 5m 09s
✔️ ansible-test-splitter SUCCESS in 2m 28s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 12m 24s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 12m 47s (non-voting)
✔️ integration-kubernetes.core-devel-3 SUCCESS in 24m 13s (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 13m 02s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 13m 13s
✔️ integration-kubernetes.core-milestone-3 SUCCESS in 23m 13s
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 14m 16s
✔️ integration-kubernetes.core-2.9-2 SUCCESS in 12m 26s
✔️ integration-kubernetes.core-2.9-3 SUCCESS in 24m 05s
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 12m 23s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 12m 06s
✔️ integration-kubernetes.core-2.10-3 SUCCESS in 23m 57s
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 13m 18s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 13m 34s
✔️ integration-kubernetes.core-with-turbo-3 SUCCESS in 24m 16s
✔️ ansible-tox-linters SUCCESS in 4m 54s
✔️ ansible-galaxy-importer SUCCESS in 5m 48s

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/kubernetes.core for 478,f01ec5d06ae23d235304882f43f5258673fdaadf

@softwarefactory-project-zuul
Copy link

Build failed.

✔️ build-ansible-collection SUCCESS in 4m 17s
ansible-test-sanity-docker-devel FAILURE in 9m 18s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 10m 09s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 56s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 09s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 35s
ansible-test-units-kubernetes-core-python38 FAILURE in 6m 09s
✔️ ansible-test-splitter SUCCESS in 2m 45s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 13m 47s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 14m 16s (non-voting)
✔️ integration-kubernetes.core-devel-3 SUCCESS in 26m 20s (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 12m 52s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 13m 14s
✔️ integration-kubernetes.core-milestone-3 SUCCESS in 24m 42s
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 14m 35s
✔️ integration-kubernetes.core-2.9-2 SUCCESS in 13m 58s
✔️ integration-kubernetes.core-2.9-3 SUCCESS in 25m 16s
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 13m 48s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 14m 04s
✔️ integration-kubernetes.core-2.10-3 SUCCESS in 24m 44s
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 12m 55s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 12m 38s
✔️ integration-kubernetes.core-with-turbo-3 SUCCESS in 23m 45s
✔️ ansible-tox-linters SUCCESS in 4m 54s
✔️ ansible-galaxy-importer SUCCESS in 5m 13s

@softwarefactory-project-zuul
Copy link

Build failed.

✔️ build-ansible-collection SUCCESS in 3m 00s
ansible-test-sanity-docker-devel FAILURE in 10m 06s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 9m 06s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 44s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 14s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 47s
ansible-test-units-kubernetes-core-python38 FAILURE in 5m 36s
✔️ ansible-test-splitter SUCCESS in 2m 29s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 13m 28s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 12m 56s (non-voting)
✔️ integration-kubernetes.core-devel-3 SUCCESS in 25m 33s (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 13m 35s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 13m 13s
✔️ integration-kubernetes.core-milestone-3 SUCCESS in 24m 33s
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 13m 59s
✔️ integration-kubernetes.core-2.9-2 SUCCESS in 14m 00s
✔️ integration-kubernetes.core-2.9-3 SUCCESS in 25m 36s
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 12m 21s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 12m 57s
✔️ integration-kubernetes.core-2.10-3 SUCCESS in 23m 41s
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 13m 23s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 12m 20s
✔️ integration-kubernetes.core-with-turbo-3 SUCCESS in 24m 07s
✔️ ansible-tox-linters SUCCESS in 4m 52s
✔️ ansible-galaxy-importer SUCCESS in 3m 56s

@softwarefactory-project-zuul
Copy link

Build failed.

✔️ build-ansible-collection SUCCESS in 3m 12s
ansible-test-sanity-docker-devel FAILURE in 10m 35s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 10m 22s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 23s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 19s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 09s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 6m 35s
✔️ ansible-test-splitter SUCCESS in 2m 42s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 12m 58s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 12m 39s (non-voting)
✔️ integration-kubernetes.core-devel-3 SUCCESS in 24m 08s (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 13m 25s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 11m 46s
✔️ integration-kubernetes.core-milestone-3 SUCCESS in 24m 27s
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 13m 35s
✔️ integration-kubernetes.core-2.9-2 SUCCESS in 13m 36s
✔️ integration-kubernetes.core-2.9-3 SUCCESS in 23m 23s
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 13m 47s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 13m 34s
✔️ integration-kubernetes.core-2.10-3 SUCCESS in 24m 29s
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 13m 43s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 13m 27s
✔️ integration-kubernetes.core-with-turbo-3 SUCCESS in 24m 19s
ansible-tox-linters FAILURE in 5m 02s
✔️ ansible-galaxy-importer SUCCESS in 5m 03s

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ build-ansible-collection SUCCESS in 3m 09s
ansible-test-sanity-docker-devel FAILURE in 10m 09s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 8m 28s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 06s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 8m 44s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 23s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 6m 11s
✔️ ansible-test-splitter SUCCESS in 2m 36s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 12m 13s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 13m 16s (non-voting)
✔️ integration-kubernetes.core-devel-3 SUCCESS in 24m 35s (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 13m 42s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 13m 20s
✔️ integration-kubernetes.core-milestone-3 SUCCESS in 24m 28s
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 14m 37s
✔️ integration-kubernetes.core-2.9-2 SUCCESS in 14m 21s
✔️ integration-kubernetes.core-2.9-3 SUCCESS in 25m 04s
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 13m 37s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 13m 36s
✔️ integration-kubernetes.core-2.10-3 SUCCESS in 24m 30s
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 13m 30s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 12m 57s
✔️ integration-kubernetes.core-with-turbo-3 SUCCESS in 25m 08s
✔️ ansible-tox-linters SUCCESS in 5m 08s
✔️ ansible-galaxy-importer SUCCESS in 4m 15s

plugins/module_utils/k8s/service.py Outdated Show resolved Hide resolved
plugins/modules/k8s_service.py Outdated Show resolved Hide resolved
plugins/modules/k8s_service.py Outdated Show resolved Hide resolved
@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ build-ansible-collection SUCCESS in 3m 21s
ansible-test-sanity-docker-devel FAILURE in 9m 11s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 10m 56s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 39s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 45s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 43s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 6m 49s
✔️ ansible-test-splitter SUCCESS in 3m 42s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 13m 24s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 13m 05s (non-voting)
✔️ integration-kubernetes.core-devel-3 SUCCESS in 24m 01s (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 14m 41s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 13m 12s
✔️ integration-kubernetes.core-milestone-3 SUCCESS in 24m 10s
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 12m 45s
✔️ integration-kubernetes.core-2.9-2 SUCCESS in 12m 39s
✔️ integration-kubernetes.core-2.9-3 SUCCESS in 23m 22s
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 11m 56s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 12m 17s
✔️ integration-kubernetes.core-2.10-3 SUCCESS in 24m 31s
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 12m 02s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 12m 18s
✔️ integration-kubernetes.core-with-turbo-3 SUCCESS in 23m 18s
✔️ ansible-tox-linters SUCCESS in 5m 12s
✔️ ansible-galaxy-importer SUCCESS in 4m 45s

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ build-ansible-collection SUCCESS in 3m 32s
ansible-test-sanity-docker-devel FAILURE in 9m 39s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 8m 41s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 10s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 33s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 12s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 6m 29s
✔️ ansible-test-splitter SUCCESS in 2m 34s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 14m 33s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 13m 31s (non-voting)
✔️ integration-kubernetes.core-devel-3 SUCCESS in 25m 30s (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 13m 03s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 13m 05s
✔️ integration-kubernetes.core-milestone-3 SUCCESS in 24m 11s
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 14m 52s
✔️ integration-kubernetes.core-2.9-2 SUCCESS in 14m 48s
✔️ integration-kubernetes.core-2.9-3 SUCCESS in 27m 32s
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 14m 12s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 12m 51s
✔️ integration-kubernetes.core-2.10-3 SUCCESS in 23m 55s
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 14m 27s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 12m 58s
✔️ integration-kubernetes.core-with-turbo-3 SUCCESS in 23m 44s
✔️ ansible-tox-linters SUCCESS in 4m 55s
✔️ ansible-galaxy-importer SUCCESS in 4m 32s

Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

if src:
if (
src
and not src.startswith("http://")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
and not src.startswith("http://")
and not src.startswith(("http://", "https://", "ftp://")):

startswith takes a tuple as well. Not a blocker, just a hint for the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion

Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ build-ansible-collection SUCCESS in 3m 10s
ansible-test-sanity-docker-devel FAILURE in 9m 28s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 11m 29s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 42s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 8m 37s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 30s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 6m 29s
✔️ ansible-test-splitter SUCCESS in 2m 33s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 16m 26s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 14m 02s (non-voting)
✔️ integration-kubernetes.core-devel-3 SUCCESS in 24m 36s (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 15m 15s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 13m 24s
✔️ integration-kubernetes.core-milestone-3 SUCCESS in 24m 58s
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 15m 51s
✔️ integration-kubernetes.core-2.9-2 SUCCESS in 13m 58s
✔️ integration-kubernetes.core-2.9-3 SUCCESS in 25m 59s
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 15m 29s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 13m 41s
✔️ integration-kubernetes.core-2.10-3 SUCCESS in 24m 34s
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 13m 56s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 13m 33s
✔️ integration-kubernetes.core-with-turbo-3 SUCCESS in 23m 32s
✔️ ansible-tox-linters SUCCESS in 5m 17s
✔️ ansible-galaxy-importer SUCCESS in 4m 14s

@abikouo abikouo added the mergeit label Jul 4, 2022
@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

✔️ build-ansible-collection SUCCESS in 3m 48s
ansible-test-sanity-docker-devel FAILURE in 10m 04s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 10m 32s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 50s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 12m 17s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 15s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 6m 03s
✔️ ansible-test-splitter SUCCESS in 2m 47s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 17m 11s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 14m 30s (non-voting)
✔️ integration-kubernetes.core-devel-3 SUCCESS in 27m 09s (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 12m 57s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 14m 09s
✔️ integration-kubernetes.core-milestone-3 SUCCESS in 27m 16s
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 15m 01s
✔️ integration-kubernetes.core-2.9-2 SUCCESS in 15m 01s
✔️ integration-kubernetes.core-2.9-3 SUCCESS in 25m 44s
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 15m 17s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 14m 30s
✔️ integration-kubernetes.core-2.10-3 SUCCESS in 24m 19s
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 14m 44s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 15m 37s
✔️ integration-kubernetes.core-with-turbo-3 SUCCESS in 25m 42s
✔️ ansible-tox-linters SUCCESS in 5m 45s
✔️ ansible-galaxy-importer SUCCESS in 4m 32s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7d0f044 into ansible-collections:main Jul 4, 2022
@maxpain
Copy link

maxpain commented Jul 28, 2022

When it will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support kubectl apply from URL
4 participants