-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support resource definition using manifest URL #478
Support resource definition using manifest URL #478
Conversation
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
…ervice and k8s_scale
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
plugins/action/k8s_info.py
Outdated
if src: | ||
if ( | ||
src | ||
and not src.startswith("http://") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and not src.startswith("http://") | |
and not src.startswith(("http://", "https://", "ftp://")): |
startswith
takes a tuple as well. Not a blocker, just a hint for the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
When it will be released? |
SUMMARY
Closes #451
ISSUE TYPE
COMPONENT NAME
k8s
k8s_scale
k8s_service