Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use post_renderer when checking 'changed' status for a helm release #588

Conversation

pauvos
Copy link
Contributor

@pauvos pauvos commented Feb 20, 2023

SUMMARY

helmdiff_check needs to use --post-renderer if configured in order to detect changes correctly

idempotency still seems to work

ISSUE TYPE
  • Bugfix Pull Request (50%)
  • Feature Pull Request (50%)
COMPONENT NAME

kubernetes.core.helm

ADDITIONAL INFORMATION
- /snap/bin/helm diff upgrade myrelease some/chart --version=1.2.3 --reset-values -f=/tmp/tmpnn0rr50h.yml
+ /snap/bin/helm diff upgrade myrelease some/chart --version=1.2.3 --reset-values --post-renderer=/tmp/somescript.sh -f=/tmp/tmpnn0rr50h.yml

`helmdiff_check` needs to use --post-renderer if configured in order
to detect changes correctly
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/2502af319ad1400cae05db2c757a640d

✔️ build-ansible-collection SUCCESS in 6m 45s
ansible-test-sanity-docker-devel RETRY_LIMIT in 16s (non-voting)
ansible-test-sanity-docker-milestone RETRY_LIMIT in 16s (non-voting)
ansible-test-sanity-docker-stable-2.9 RETRY_LIMIT in 18s
ansible-test-sanity-docker-stable-2.11 RETRY_LIMIT in 17s
ansible-test-sanity-docker-stable-2.12 RETRY_LIMIT in 16s
ansible-test-units-kubernetes-core-python38 RETRY_LIMIT in 17s
✔️ ansible-test-splitter SUCCESS in 4m 36s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 13m 00s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 8m 45s (non-voting)
✔️ integration-kubernetes.core-devel-3 SUCCESS in 13m 13s (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 18m 34s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 15m 35s
✔️ integration-kubernetes.core-milestone-3 SUCCESS in 8m 36s
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 14m 20s
✔️ integration-kubernetes.core-2.9-2 SUCCESS in 8m 44s
✔️ integration-kubernetes.core-2.9-3 SUCCESS in 8m 19s
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 13m 31s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 8m 32s
✔️ integration-kubernetes.core-2.10-3 SUCCESS in 6m 54s
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 16m 29s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 8m 44s
✔️ integration-kubernetes.core-with-turbo-3 SUCCESS in 10m 00s
✔️ ansible-tox-linters SUCCESS in 10m 12s
✔️ ansible-test-changelog SUCCESS in 4m 24s
ansible-galaxy-importer RETRY_LIMIT in 15s

@gravesm
Copy link
Member

gravesm commented Apr 4, 2023

recheck

@gravesm gravesm closed this Apr 5, 2023
@gravesm gravesm reopened this Apr 5, 2023
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/89e1e2287cc64b83a8ea5f423d38a6f4

✔️ build-ansible-collection SUCCESS in 7m 11s
ansible-test-sanity-docker-devel FAILURE in 8m 28s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 11m 51s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 21s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 54s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 21s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 6m 00s
✔️ ansible-test-splitter SUCCESS in 4m 48s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 15m 21s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 11m 12s (non-voting)
integration-kubernetes.core-devel-3 POST_FAILURE in 8m 48s (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 17m 50s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 11m 52s
✔️ integration-kubernetes.core-milestone-3 SUCCESS in 8m 00s
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 14m 19s
✔️ integration-kubernetes.core-2.9-2 SUCCESS in 13m 35s
✔️ integration-kubernetes.core-2.9-3 SUCCESS in 8m 20s
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 13m 51s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 9m 24s
✔️ integration-kubernetes.core-2.10-3 SUCCESS in 7m 39s
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 17m 08s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 8m 58s
✔️ integration-kubernetes.core-with-turbo-3 SUCCESS in 7m 11s
✔️ ansible-tox-linters SUCCESS in 10m 56s
✔️ ansible-test-changelog SUCCESS in 4m 34s
✔️ ansible-galaxy-importer SUCCESS in 3m 52s

@gravesm gravesm added the mergeit label Apr 5, 2023
@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/57bc9eea10bb48d79d96142af8835be1

✔️ build-ansible-collection SUCCESS in 7m 11s
ansible-test-sanity-docker-devel FAILURE in 8m 56s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 9m 17s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 15s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 00s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 16s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 6m 15s
✔️ ansible-test-splitter SUCCESS in 4m 43s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 13m 21s (non-voting)
✔️ integration-kubernetes.core-devel-2 SUCCESS in 13m 47s (non-voting)
✔️ integration-kubernetes.core-devel-3 SUCCESS in 7m 50s (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 14m 01s
✔️ integration-kubernetes.core-milestone-2 SUCCESS in 9m 49s
✔️ integration-kubernetes.core-milestone-3 SUCCESS in 7m 18s
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 12m 46s
✔️ integration-kubernetes.core-2.9-2 SUCCESS in 9m 06s
✔️ integration-kubernetes.core-2.9-3 SUCCESS in 13m 16s
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 13m 58s
✔️ integration-kubernetes.core-2.10-2 SUCCESS in 10m 44s
✔️ integration-kubernetes.core-2.10-3 SUCCESS in 8m 58s
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 14m 08s
✔️ integration-kubernetes.core-with-turbo-2 SUCCESS in 10m 58s
✔️ integration-kubernetes.core-with-turbo-3 SUCCESS in 8m 49s
✔️ ansible-tox-linters SUCCESS in 10m 25s
✔️ ansible-test-changelog SUCCESS in 4m 20s
✔️ ansible-galaxy-importer SUCCESS in 3m 28s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants