-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing @adParams for Rename-ADObject and Move-ADObject #54
Comments
Ran into yet another problem, module is not using the same DC, when deleting ous. Get-ADObject is not using the proper params, subsequent calls to Set-ADObject or Remove-ADObject will fail. It is really important to always use the same domain controller, when talking to AD. If not you will get "strange" unexpected results, because of replication delays. |
Thanks for the bug report and sorry for the delay, the PR #61 should fix up this issue.
Is this related to the same missing splatted variables here or is it for something else? I just want to check if there is more that can be done here. |
Thanks for your answer. This is all related to the same missing splatted variables. PR #61 fixes the Move-ADObject stuff, I guess, but I think you missed the one, where Get-ADObject is called before removing AccidentalDeletion when state is absent. |
Thanks for the pickup, just pushed a commit that adds that one. |
SUMMARY
Moving or Renaming Objects doesn't work as expected, specified dc is not used, auth should not be working (I guess)
ISSUE TYPE
COMPONENT NAME
_ADObject.psm1 used by all modules
Move-ADObejct and Rename-ADObject is missing @adParams
ANSIBLE VERSION
COLLECTION VERSION
CONFIGURATION
OS / ENVIRONMENT
not relevant
STEPS TO REPRODUCE
EXPECTED RESULTS
The Group is renamed/moved using the DC specified by domain_server
ACTUAL RESULTS
The Group is renamed/moved using the default DC of the server connected to
Leads to replcation delays etc.
The text was updated successfully, but these errors were encountered: