Add simple if/else statement to honor ansible_check_mode within CLI modules #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rwise autosupport is not properly enabled as 'disable' evaluates as True
lonico
approved these changes
Sep 7, 2022
carchi8py
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #102
Just a very simple fix to honor ansible_check_mode and make the modules safer to use for everyone.
ISSUE TYPE
COMPONENT NAME
na_ontap_command
na_ontap_rest_cli
ADDITIONAL INFORMATION
Unless this logic is added, the "check_mode" option in ansible is not honored.
Unsuspecting users will expect to be protected by the -C command line option,
which will be passed to the module... but ignored.
In its current implementation, the module will execute a command even when a user would not expect it.
My fix merely restores this behavior by having the module merely state what it would do instead.