Adding more tests/ changing errors for REST calls #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
=======================================
Coverage 90.65% 90.66%
=======================================
Files 301 301
Lines 51052 51065 +13
Branches 6567 6566 -1
=======================================
+ Hits 46282 46298 +16
Misses 2836 2836
+ Partials 1934 1931 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lonico
reviewed
Aug 22, 2022
| @@ -122,7 +122,7 @@ def get_ems_destination(self, name): | |||
| fields = 'name,type,destination,filters.name' | |||
| query = dict(name=name, fields=fields) | |||
| record, error = rest_generic.get_one_record(self.rest_api, api, query) | |||
| self.fail_on_error(error) | |||
| self.fail_on_error(error, 'GET') | |||
There was a problem hiding this comment.
I think it would look better as
self.fail_on_error(error, 'fetching EMS destinations for %s' % name)
what do you think?
There was a problem hiding this comment.
Agreed. Let me update it first.
| @@ -145,12 +145,12 @@ def create_ems_destination(self): | |||
| 'filters': self.generate_filters_list(self.parameters['filters']) | |||
| } | |||
| dummy, error = rest_generic.post_async(self.rest_api, api, body) | |||
| self.fail_on_error(error) | |||
| self.fail_on_error(error, 'POST') | |||
There was a problem hiding this comment.
and then
self.fail_on_error(error, 'creating EMS destinations for %s' % name)
|
Good for me, but if you want to improve error messages, I would made them more end user friendly. |
lonico
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding few more tests for na_ontap_ems_destination and changing error messages for REST.
ISSUE TYPE
COMPONENT NAME
na_ontap_ems_destination
ADDITIONAL INFORMATION
I decided to add a few more tests to increase test coverage.
Also decided that tests for REST methods could be a bit more helpful if they would specify the method that was called.
While working on this PR I realized that the loop responsible for running helper methods should actually have only one
elif- no scenario exists whereself.na_helper.changedis True and neithercd_actionnormodifyis in one of the values listed right now.