Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Open vSwitch bond management module #58

Merged
merged 8 commits into from Nov 24, 2020

Conversation

busterswt
Copy link
Contributor

SUMMARY

Adds a new Open vSwitch bond management module with support for multiple other_config and set commands necessary for multiple interfaces, including DPDK-enabled interfaces.

Based on the existing openvswitch_port module.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

openvswitch_bond

ADDITIONAL INFORMATION

The existing Open vSwitch modules do not address the configuration and management of bonded interfaces. This module allows users to create and add bonded interfaces to existing bridges by leveraging the ovs-vsctl add-bond command and associated configuration options.

The existing Open vSwitch modules do not address the configuration
and management of bonded interfaces. This module allows users to
create and add bonded interfaces to existing bridges by leveraging
the ovs-vsctl add-bond command and associated configuration options.
@Qalthos Qalthos self-requested a review November 4, 2020 14:16
Copy link

@Qalthos Qalthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need at minimum to add a changelog fragment and some unit tests for the module before this can be merged.

plugins/modules/openvswitch_bond.py Outdated Show resolved Hide resolved
Copy link

@Qalthos Qalthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine otherwise

tests/unit/modules/network/ovs/test_openvswitch_bond.py Outdated Show resolved Hide resolved
tests/unit/modules/network/ovs/test_openvswitch_bond.py Outdated Show resolved Hide resolved
@NilashishC NilashishC added the gate Gate PR in Zuul CI label Nov 24, 2020
@ansible-zuul ansible-zuul bot merged commit 2145baf into ansible-collections:main Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate Gate PR in Zuul CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants