New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Open vSwitch bond management module #58
Merged
ansible-zuul
merged 8 commits into
ansible-collections:main
from
busterswt:add-bond-support
Nov 24, 2020
Merged
Adds Open vSwitch bond management module #58
ansible-zuul
merged 8 commits into
ansible-collections:main
from
busterswt:add-bond-support
Nov 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing Open vSwitch modules do not address the configuration and management of bonded interfaces. This module allows users to create and add bonded interfaces to existing bridges by leveraging the ovs-vsctl add-bond command and associated configuration options.
Qalthos
requested changes
Nov 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will also need at minimum to add a changelog fragment and some unit tests for the module before this can be merged.
Qalthos
requested changes
Nov 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine otherwise
Qalthos
approved these changes
Nov 24, 2020
NilashishC
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds a new Open vSwitch bond management module with support for multiple other_config and set commands necessary for multiple interfaces, including DPDK-enabled interfaces.
Based on the existing openvswitch_port module.
ISSUE TYPE
COMPONENT NAME
openvswitch_bond
ADDITIONAL INFORMATION
The existing Open vSwitch modules do not address the configuration and management of bonded interfaces. This module allows users to create and add bonded interfaces to existing bridges by leveraging the
ovs-vsctl add-bond
command and associated configuration options.