This repository has been archived by the owner on May 28, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection checklist #90
Collection checklist #90
Changes from 5 commits
aad7feb
f12e95c
bce4939
54da58e
74012f0
3b8abfa
d57ded9
727d197
4ef1ca9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roaming around the collections i noticed a bit strange things as parts of FQCNs like
vyos.vyos.*
. We definitely should put some recommendations here. Maybe later thoughThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, indeed, and with all modules name starting with also
vyos_
so you end up withvyos.vyos.vyos_foo
... . I tried to open issues about that on some projects, but now it's a bit too late.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Andersson007 Do you think we should providing some naming advice for collections ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmillemathias sure, it could be general points without giving concrete examples how people shouldn't do :)
E.g. meaning (and we can see something similar in every book about programming)
Something like that.
I definitely shoul think about it. If you feel the same and have something to suggest, it would be really great:)