Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Enable the integration tests for targets that were disabled earlier #470

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GomathiselviS
Copy link
Contributor

SUMMARY

Enabling the tests to understand the reason why they were disabled earlier.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.18%. Comparing base (f5d7fd2) to head (4aa01d9).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #470   +/-   ##
=======================================
  Coverage   34.18%   34.18%           
=======================================
  Files         143      143           
  Lines       11040    11040           
  Branches     2291     2291           
=======================================
  Hits         3774     3774           
  Misses       7266     7266           
Flag Coverage Δ
sanity 34.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@mariolenz
Copy link
Collaborator

recheck

Copy link

@mariolenz
Copy link
Collaborator

@GomathiselviS I don't know why this fails. Actually, I don't understand the logs at all. Do you have an idea what's wrong here?

@GomathiselviS
Copy link
Contributor Author

@GomathiselviS I don't know why this fails. Actually, I don't understand the logs at all. Do you have an idea what's wrong here?

@mariolenz , these tests were disabled previously. I wanted to investigate why they are failing, so I've enabled them for now. I'll look into the issues next week and keep you updated.
It fails with the following error

ERROR! the playbook: playbook.yaml could not be found

@mariolenz
Copy link
Collaborator

It fails with the following error

ERROR! the playbook: playbook.yaml could not be found

Yes, that just what I don't understand. I don't know what this error wants to tell me. Well, maybe you find out more. Good luck!

@mariolenz
Copy link
Collaborator

@alinabuzachis Great! Thanks for having a look at this and find out what's going wrong!

Now the question is: What's better / easier, changing the script or renaming playbook.yaml to playbook.yml?

@mariolenz
Copy link
Collaborator

@GomathiselviS @alinabuzachis Any news on this?

@alinabuzachis
Copy link
Collaborator

Recheck

Copy link

@alinabuzachis
Copy link
Collaborator

recheck

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants