Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for var-spacing in ansible-lint #541

Closed
wants to merge 2 commits into from
Closed

Improvements for var-spacing in ansible-lint #541

wants to merge 2 commits into from

Conversation

ppuschmann
Copy link
Contributor

The rule was formerly known as jinja[spacing].

Copy link
Contributor

@nre-ableton nre-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thanks! 🎉 However, before we merge it, please remove the var-naming suppression can be removed from .ansible-lint.

Thanks! If you don't have time to make the above changes, please let me know and I will fix (and force-push) to your branch.

tasks/install_linux_repo.yml Show resolved Hide resolved
tasks/main.yml Outdated Show resolved Hide resolved
The rule was formerly known as `jinja[spacing]`.

Removed all issues --> remove the entry in `.ansible-lint`
This should fix the pipeline :-)
@nre-ableton
Copy link
Contributor

@ppuschmann Thanks for responding to my comments. I'm really busy this week with a project that has a deadline before the Easter holidays, but I'll re-review your changes as soon as I can.

Copy link
Contributor

@nre-ableton nre-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll merge this as soon as CI goes green. Thanks again for your contribution! 👍

@nre-ableton
Copy link
Contributor

nre-ableton commented Apr 20, 2023

CI problems have been fixed in #547, but unfortunately that has led to some merge conflicts. Namely, the commit 84bb7cc ("Add pipefail to shell-tasks") must be dropped. See further explanation here as to why we sadly can't use set -o pipefail, if you are curious.

So please rebase and drop the commit, and I'll go ahead and merge this PR.

Normally I would rebase this branch myself to save you the trouble, but I don't want to force-push your branch and delete your commits, so I would prefer if you could do it. 👍 If you aren't sure how to rewrite the history and drop the commit, just give me your blessing and I'll take care of it.

@ppuschmann ppuschmann closed this Aug 23, 2023
@ppuschmann ppuschmann deleted the improve-var-spacing branch August 23, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants