Remove support for py36 and py37 #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
fix/v6
branch
3 times, most recently
from
6bac5b4
to
23464e4
Compare
ssbarnea
requested review from
relrod,
ganeshrn,
priyamsahoo,
cidrblock,
tadeboro,
webknjaz and
bcoca
and removed request for
a team
ssbarnea
force-pushed
the
fix/v6
branch
2 times, most recently
from
90bdbab
to
398c0f9
Compare
|
I think this change should add a config for Patchback, then. And maybe for |
That could count as scope creeping. Anything that is not directly needed should go in follow-ups. In fact, I suppose that backports will likely be done manually as I expect to see the codebase diverge. |
tadeboro
approved these changes
Feb 6, 2022
ganeshrn
approved these changes
Feb 7, 2022
cidrblock
approved these changes
Feb 7, 2022
|
+1 from me. |
ssbarnea
force-pushed
the
fix/v6
branch
4 times, most recently
from
2f3e17f
to
f425817
Compare
As part of reduce testing complexity and getting ansible-lint in sync with ansible-core, we drop support for older python versions. This change marks the start of `6.x` and once is merged we will create a `stable/5.x` for the last comment before it. That branch will be used to backport changes needed for the older versions, at least until we can make a full release of 6.x. One additional reason for making this move is a recent explosion of dropping support for py36 and sometimes even py37 on other dependencies, such pytest, coverage, pip-compile, tomli.
ssbarnea
added a commit
to ansible/ansible-compat
that referenced
this pull request
Feb 25, 2022
Related: ansible/molecule#3436 Related: ansible/ansible-lint#1850
ssbarnea
added a commit
to ansible/ansible-compat
that referenced
this pull request
Feb 25, 2022
Related: ansible/molecule#3436 Related: ansible/ansible-lint#1850
ssbarnea
added a commit
to ansible/ansible-compat
that referenced
this pull request
Feb 25, 2022
Related: ansible/molecule#3436 Related: ansible/ansible-lint#1850
ssbarnea
added a commit
to ansible/ansible-compat
that referenced
this pull request
Feb 25, 2022
ziegenberg
added a commit
to ziegenberg/ansible-lint
that referenced
this pull request
Apr 29, 2022
PR ansible#1850 removed support for python 3.6 and python 3.7 so this should be reflected in the package metadata for setuptools Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/ansible-lint
that referenced
this pull request
Apr 29, 2022
Since PR ansible#1850 removed support for python 3.6 and python 3.7 some special code paths can be now be removed. This also allows updating some test and typing dependencies which very pinned for python 3.6 and python 3.7 support. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of reduce testing complexity and getting ansible-lint in sync with
ansible-core, we will requirepython_version>=3.8.This change marks the start of
6.xand once is merged we will create astable/5.xfor the last comment before it. That branch will be used to backport changes needed for the older versions, at least until we can make a full release of 6.x.One additional reason for making this move is a recent explosion of dependencies dropping support for py36 or even py37:
pytest,coverage,pip-compile,tomli.Please mark your support or lack of on this change as we are aware that it may upset some users that are still stuck on older platform as it will be harder for them to get bugfixes.
Related: ansible/molecule#3436