Improve cli argument handling #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziegenberg
force-pushed
the
gracefully-handle-wrong-cli-arguments
branch
from
152baa6
to
471da7c
Compare
With PR ansible#1450 optional rules with the 'opt-in' tag were introduced and according to the docs, listing rules and tags should also list the opt-in rules. Fixes: ansible#2068 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
We either print a list of rules or a list of tags, but never both at the same time. So it makes no sense to allow giving both arguments at the same time. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Having short cli arguments for often used options is nice to have when using the command in an interactive shell. For writing scripts it would be better to have long forms of arguments as it increases the readebility. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
gracefully-handle-wrong-cli-arguments
branch
from
471da7c
to
d4c3ae7
Compare
ssbarnea
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
-f) with listing rules (-L)-Land-Tinto a mutually exclusive groupWe either print a list of rules or a list of tags, but never both at the same time. So it makes no sense to allow giving both arguments at the same time.
Having short CLI arguments for often used options is nice to have when using the command in an interactive shell. For writing scripts, it would be better to have long forms of arguments as it increases the readability.
ℹ️ Note: This PR contains commits from PR #2098, which should be merged first.