Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key-order: now sorts block/rescue/always to the bottom #2454

Merged
merged 1 commit into from Sep 23, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Sep 19, 2022

  • refactor key ordering to allow us to sort all keys
  • ensure block/rescue/always are sorted last

Related: #2455
Related: #2456
Fixes: #2222

@github-actions github-actions bot added the bug label Sep 19, 2022
@ssbarnea ssbarnea force-pushed the fix/key-order branch 2 times, most recently from b3d4b07 to 1ec6223 Compare September 23, 2022 17:06
@ssbarnea ssbarnea marked this pull request as ready for review September 23, 2022 17:07
@ssbarnea ssbarnea requested review from a team as code owners September 23, 2022 17:07
@ssbarnea ssbarnea changed the title Extend key-order key to sort more keys than the name key-order: now sorts block/rescue/always to the bottom Sep 23, 2022
@ssbarnea ssbarnea force-pushed the fix/key-order branch 3 times, most recently from eb5e1f9 to bf721e9 Compare September 23, 2022 18:12
- refactor key ordering to allow us to sort all keys
- ensure `block`/`rescue`/`always` are sorted `last`
@ssbarnea ssbarnea merged commit 01d2e6d into ansible:main Sep 23, 2022
@ssbarnea ssbarnea deleted the fix/key-order branch September 23, 2022 19:52
davedittrich pushed a commit to davedittrich/ansible-lint that referenced this pull request Sep 27, 2022
- refactor key ordering to allow us to sort all keys
- ensure `block`/`rescue`/`always` are sorted `last`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant