Update key-order check to check all keys #2222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Will update this soon - struggling to find time to debug the typing errors recently |
jeefberkey
force-pushed
the
all-key-order
branch
from
0d24534
to
89f4f7e
Compare
|
@jeefberkey Any chance you can resume work on this change? It was a nice addition to make to the linter. |
jeefberkey
force-pushed
the
all-key-order
branch
from
89f4f7e
to
ddb4a16
Compare
A user can set the key_order setting to one of the following options: * default - checks only the order of name and action * enhanced - checks a smaller list of possible keys * everything - checks a list containing every key
jeefberkey
force-pushed
the
all-key-order
branch
from
ddb4a16
to
13b74a8
Compare
|
@ssbarnea I picked this back up a few days ago - but my tests keep on failing for things I have not modified. Can you help me with that? Also, it seems like the eco test have changed. Didn't the results used to be checked in to git? It looks like the test still uses |
|
Everything seems well now - I looked for a bit for a comprehensive list of allowed keys, but never found one. Hopefully the yaml file makes it a little easier to maintain. @ssbarnea Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user can set the key_order setting to one of the following options: