Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

role-name[path]: Now detects use of paths when including roles #2532

Merged
merged 1 commit into from Oct 31, 2022
Merged

role-name[path]: Now detects use of paths when including roles #2532

merged 1 commit into from Oct 31, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Oct 1, 2022

Fixes: #2502

@ssbarnea ssbarnea requested review from a team as code owners October 1, 2022 19:25
@ssbarnea ssbarnea added the bug label Oct 1, 2022
@ssbarnea ssbarnea marked this pull request as draft October 1, 2022 19:25
@MarkusTeufelberger
Copy link
Contributor

Hehe, that's one way of fixing this! ;-)

@MarkusTeufelberger
Copy link
Contributor

Btw. this likely also should be caught by the schema for ansible playbooks - role names probably should conform to a certain regex instead of just being a generic string.

@ssbarnea ssbarnea marked this pull request as ready for review October 31, 2022 00:11
@ssbarnea ssbarnea merged commit fa2af5a into ansible:main Oct 31, 2022
@ssbarnea ssbarnea deleted the fix/role-name-path branch October 31, 2022 01:04
@ssbarnea ssbarnea mentioned this pull request Nov 11, 2022
Merged
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this pull request Nov 11, 2022
@ssbarnea
role-name[path]: Now detects use of paths when including roles (ansib…
7f31cd8 
…le#2532)

Fixes: ansible#2502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

@trishnaguha trishnaguha Awaiting requested review from trishnaguha trishnaguha is a code owner automatically assigned from ansible/devtools

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

role-name doesn't recognize roles in subpaths
2 participants
@ssbarnea @MarkusTeufelberger