role-name[path]: Now detects use of paths when including roles

Fixes: #2502

examples/roles/subfolder/other_role/tasks/main.yml

@@ -0,0 +1,4 @@
+---
+- name: Foo
+  debug:
+    msg: "Hello!"

src/ansiblelint/config.py

@@ -37,6 +37,7 @@
     "name[play]",
     "role-name",
     "warning[empty-playbook]",  # because ansible considers it warning only
+    "role-name[path]",  # too new
 ]
 
 DEFAULT_KINDS = [

src/ansiblelint/constants.py

@@ -136,8 +136,10 @@ def main():
 }
 
 ROLE_IMPORT_ACTION_NAMES = {
-    "import_role",
     "ansible.builtin.import_role",
-    "include_role",
     "ansible.builtin.include_role",
+    "ansible.legacy.import_role",
+    "ansible.legacy.include_role",
+    "import_role",
+    "include_role",
 }

src/ansiblelint/rules/role_name.md

@@ -7,6 +7,10 @@ Role names must also start with an alphabetic character.
 
 For more information see the [roles directory](https://docs.ansible.com/ansible/devel/dev_guide/developing_collections_structure.html#roles-directory) topic in Ansible documentation.
 
+`role-name[path]` message tells you to avoid using paths when importing roles.
+You should only rely on Ansible's ability to find the role and refer to them
+using fully qualified names.
+
 ## Problematic Code
 
 ```yaml

src/ansiblelint/rules/role_name.py

@@ -23,8 +23,9 @@
 
 import re
 from pathlib import Path
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, Any
 
+from ansiblelint.constants import ROLE_IMPORT_ACTION_NAMES
 from ansiblelint.file_utils import Lintable
 from ansiblelint.rules import AnsibleLintRule
 from ansiblelint.utils import parse_yaml_from_file
@@ -53,12 +54,30 @@ class RoleNames(AnsibleLintRule):
     severity = "HIGH"
     done: list[str] = []  # already noticed roles list
     tags = ["deprecations", "metadata"]
-    version_added = "v4.3.0"
+    version_added = "v6.8.5"
 
     def __init__(self) -> None:
         """Save precompiled regex."""
         self._re = re.compile(ROLE_NAME_REGEX)
 
+    def matchtask(
+        self, task: dict[str, Any], file: Lintable | None = None
+    ) -> list[MatchError]:
+        results = []
+        if task["action"]["__ansible_module__"] in ROLE_IMPORT_ACTION_NAMES:
+            name = task["action"].get("name", "")
+            # breakpoint()
+            if "/" in name:
+                results.append(
+                    self.create_matcherror(
+                        "Avoid using paths when importing roles.",
+                        filename=file,
+                        linenumber=task["__line__"],
+                        tag=f"{self.id}[path]",
+                    )
+                )
+        return results
+
     def matchdir(self, lintable: Lintable) -> list[MatchError]:
         return self.matchyaml(lintable)