✨ Add support for nomad's client template config #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rendanic can you review (since basically this is a copy of the fix for plugin config)🙏 |
fairglen
force-pushed
the
leo/client_template_config
branch
2 times, most recently
from
0d26282
to
5129709
Compare
RCM7
approved these changes
Nov 2, 2023
|
@fairglen thank you for your PR. I added molecule tests to ansible-community/ansible-nomad:master. Please update your feature branch with current master. |
* 🐛 Fix bug with indentation * 🐛 Further fixing of failing to render template config when empty param
* 🐛 Fix bug with indentation * 🐛 Further fixing of failing to render template config when empty param
beechesII
force-pushed
the
leo/client_template_config
branch
from
86f92c0
to
f723036
Compare
Rendanic
pushed a commit
to opitzconsulting/ansible-nomad
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Main theme: Adding support for nomad's client template config
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
🔒 Security concerns: No, this PR does not introduce any obvious security concerns. It's a configuration enhancement and doesn't involve any sensitive data handling or risky operations