based on feedback - extend the tests of when to add a period

ansible-community · May 7, 2024 · bde13d2 · bde13d2
1 parent 63b547f
commit bde13d2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/antsibull_changelog/plugins.py b/src/antsibull_changelog/plugins.py
@@ -80,7 +80,7 @@ def from_dict(
         for plugin_type, plugin_data in data.items():
             for plugin_name, plugin_details in plugin_data.items():
                 description = plugin_details["description"]
-                if description and not description.endswith("."):
+                if description and not description.endswith((".", ",", "!", "?")):
                     description += "."
                 plugins.append(
                     PluginDescription(

diff --git a/tests/functional/test_changelog_basic_collection.py b/tests/functional/test_changelog_basic_collection.py
@@ -1111,7 +1111,7 @@ def test_changelog_release_simple(  # pylint: disable=redefined-outer-name
         },
         {
             "name": "test_new4",
-            "description": "This is yet another test module!.",
+            "description": "This is yet another test module!",
             "namespace": "",
         },
     ]
@@ -1186,7 +1186,7 @@ def test_changelog_release_simple(  # pylint: disable=redefined-outer-name
 New Modules
 -----------
 
-- acme.test.test_new4 - This is yet another test module!.
+- acme.test.test_new4 - This is yet another test module!
 
 Foo
 ~~~