New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make yaml output pass ansible-lint
#160
base: main
Are you sure you want to change the base?
Conversation
b21f35d
to
8aef2d8
Compare
Not sure if what the nox linter is complaining about is related to my changes.
|
Thanks for your contribution! Please make this behavior configurable. It should not be the default IMO. (#161 fixes the mypy linting error; it is due to a newer version of mypy.) |
Ok sure, although I don't see what harm it could do to have it as the default format. |
Signed-off-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: gardar <gardar@users.noreply.github.com>
8aef2d8
to
2719e87
Compare
This causes huge changes in changelogs/changelog.yaml in many collections.
I would add a setting to changelogs/config.yaml. |
Signed-off-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: gardar <gardar@users.noreply.github.com>
@felixfontein this should be all ready now. |
f5560f5
to
23211e6
Compare
23211e6
to
8f787cc
Compare
Signed-off-by: gardar <gardar@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Signed-off-by: gardar <gardar@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
---
to the header of the file.fixes: #91
fixes: #152