Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3] Remove residual support for old ansible versions #123

Closed
gotmax23 opened this issue Dec 1, 2023 · 3 comments · Fixed by #132
Closed

[v3] Remove residual support for old ansible versions #123

gotmax23 opened this issue Dec 1, 2023 · 3 comments · Fixed by #132
Assignees
@gotmax23
Milestone
antsibull-core v3

Comments

@gotmax23
Copy link
Collaborator

gotmax23 commented Dec 1, 2023

antsibull only supports building ansible 6.0.0 releases, but antsibull-core still has residual code for building older ansible releases and for dealing with ansible-base. We should identify that code and remove it.
@gotmax23 gotmax23 added this to the antsibull-core v3 milestone Dec 1, 2023
gotmax23 added a commit to gotmax23/antsibull-core that referenced this issue Dec 23, 2023
@gotmax23
deprecate support for old ansible versions <6.0.0
4d24afe 
Fixes: ansible-community#123
@gotmax23 gotmax23 mentioned this issue Dec 23, 2023
Draft
gotmax23 added a commit to gotmax23/antsibull-core that referenced this issue Dec 24, 2023
@gotmax23
deprecate support for old ansible versions <6.0.0
26a3a1e 
Relates: ansible-community#123
@felixfontein
Copy link
Collaborator

I think this mainly covers:

  • ansible-base support;
  • dependency files: _acd_version and _ansible_base_version in deps and build files; special cases while writing these files;

@gotmax23
Copy link
Collaborator Author

Right. I started working on this last night.

@gotmax23 gotmax23 self-assigned this Dec 24, 2023
@felixfontein
Copy link
Collaborator

I mainly went through to get an idea of what this will be myself, since I could only come up with ansible-base when first thinking about this; I didn't intend to work on it (except in case you won't :) ).

gotmax23 added a commit to gotmax23/antsibull-core that referenced this issue Jan 21, 2024
@gotmax23
Remove support for old ansible versions
b970dc3 
Fixes: ansible-community#123
@gotmax23 gotmax23 mentioned this issue Jan 21, 2024
Merged
felixfontein pushed a commit that referenced this issue Jan 23, 2024
@gotmax23
[v3] Remove support for old ansible versions (#132)
43ce9da 
* Remove support for old ansible versions

Fixes: #123

* ansible_core: remove get_ansible_core_package_name()

* add changelog entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gotmax23 gotmax23

Labels
None yet
Projects
None yet
Milestone
antsibull-core v3
Development

Successfully merging a pull request may close this issue.

[v3] Remove support for old ansible versions gotmax23/antsibull-core
2 participants
@felixfontein @gotmax23