Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for ansible-core 2.12 and earlier #120

Conversation

felixfontein
Copy link
Collaborator

Allows to remove quite some code for docs parsing, and allows to use ansible-galaxy collection list --format json instead of parsing its text output.

@felixfontein felixfontein mentioned this pull request Apr 9, 2023
Copy link
Collaborator

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides that one stray comment.

@@ -17,7 +17,7 @@

#: Valid choices for a logging level field
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be in the wrong place

@felixfontein
Copy link
Collaborator Author

Note to self: antsibull-core 2.0.0 can likely remove docs-specific options from the default context.

@felixfontein felixfontein merged commit 489da64 into ansible-community:main Apr 11, 2023
9 checks passed
@felixfontein felixfontein deleted the drop-ansible-core-2.12-and-earlier branch April 11, 2023 04:23
@felixfontein
Copy link
Collaborator Author

@gotmax23 thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants