Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: nox: set up environments in a separate step #256

Merged
merged 1 commit into from
Mar 13, 2024
Merged

CI: nox: set up environments in a separate step #256

merged 1 commit into from
Mar 13, 2024

Conversation

felixfontein
Copy link
Collaborator

This should clean up the actual test output without having to remove -v.

@felixfontein
Copy link
Collaborator Author

@gotmax23 what do you think of this solution?

gotmax23
gotmax23 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this!

In a follow up PR, we should probably separate the two jobs into a matrix like we have in the antsibull repository to avoid code duplication.

@felixfontein felixfontein merged commit a905d37 into ansible-community:main Mar 13, 2024
12 checks passed
@felixfontein felixfontein deleted the ci branch March 13, 2024 06:24
@felixfontein
Copy link
Collaborator Author

Thanks for reviewing this!

This was referenced Mar 16, 2024
Merged
Merged
Merged
Merged
@felixfontein
Copy link
Collaborator Author

Adding the matrix in #259.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotmax23 gotmax23 gotmax23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixfontein @gotmax23