Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop code for old ansible versions #472

Closed
gotmax23 opened this issue Dec 8, 2022 · 2 comments · Fixed by #477
Closed

Drop code for old ansible versions #472

gotmax23 opened this issue Dec 8, 2022 · 2 comments · Fixed by #477

Comments

@gotmax23
Copy link
Contributor

gotmax23 commented Dec 8, 2022

There's special cases for old ansible versions sprinkled throughout the codebase that add extra complexity. I think we should declare how many ansible versions back we support, and cleanup code for versions older than that.
@felixfontein
Copy link
Collaborator

I quickly looked through the code, I think the current version covers everything from 6.0.0rc1 on. How about dropping support for everything before that?

(The only exception is the python_version code in _extract_python_requires which needs Ansible 6.5.0+. I'm OK with leaving that one in.)

Generally I would say we should support at least the current and the previous major release train. I don't think there's much worth in supporting more than that, as users can always switch to older verions of antsibull. WDYT?

gotmax23 added a commit to gotmax23/antsibull that referenced this issue Dec 10, 2022
@gotmax23
ansible setup.py: Remove code for old versions
ad5cfe0 
Relates: ansible-community#472
gotmax23 added a commit to gotmax23/antsibull that referenced this issue Dec 10, 2022
@gotmax23
ansible setup.py: Remove code for old versions
daafc88 
Relates: ansible-community#472
gotmax23 added a commit to gotmax23/antsibull that referenced this issue Dec 10, 2022
@gotmax23
ansible setup.py: Remove code for old versions
ac19497 
Relates: ansible-community#472
gotmax23 added a commit to gotmax23/antsibull that referenced this issue Dec 10, 2022
@gotmax23
ansible setup.py: Remove code for old versions
05c5abf 
Relates: ansible-community#472
@felixfontein felixfontein mentioned this issue Mar 26, 2023
Merged
gotmax23 added a commit to gotmax23/antsibull that referenced this issue Apr 18, 2023
@gotmax23
ansible setup.py: Remove code for old versions
993595a 
Relates: ansible-community#472
This was referenced Apr 19, 2023
Merged
Merged
@gotmax23
Copy link
Contributor Author

I opened #515 to deprecate support for < 6.0.0 and am updating #477 to remove it completely.

gotmax23 added a commit to gotmax23/antsibull that referenced this issue May 5, 2023
@gotmax23
ansible setup.py: Remove code for old versions
b1371a3 
Relates: ansible-community#472
felixfontein pushed a commit that referenced this issue May 5, 2023
@gotmax23
remove support for building ansible < 6.0.0 (#477)
fe1f294 
* ansible setup.py: Remove code for old versions

Relates: #472

* remove other code for < ansible 6

* error when trying to build an unsupported version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove support for building ansible < 6.0.0 gotmax23/antsibull
2 participants
@felixfontein @gotmax23