-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid prereleases when creating the .build file #298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2021
Does this need to be toggleable? Or somehow reviewable/settable on a
per-collection basis?
I'm thinking that we might know that some collections are making
prereleases when we cut an alpha or beta but their schedule will mean that
their final (or release candidate or late beta) will be out before our
final release.
…On Sun, Aug 1, 2021, 3:36 PM Felix Fontein ***@***.***> wrote:
@felixfontein <https://github.com/felixfontein> requested your review on:
#298 <#298> Avoid
prereleases when creating the .build file.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#298 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABTCWUBLUFHCDUM36GBULTT2XD63ANCNFSM5BLSOSIA>
.
|
Hmm, I never replied to this one :) I think it's best to only have a global toggle, and not a per-collection toggle, since for alphas the global toggle should be fine, and for betas we can still manually include pre-releases in the build file if we really need that for some specific collections. (I would expect that this happens only very seldomly anyway, or even better never.) |
dmsimard
reviewed
Jan 6, 2022
dmsimard
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes CI.