Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct plugin type instead of module in ansible.builtin disclaimer #320

Merged
merged 2 commits into from Oct 20, 2021

Conversation

felixfontein
Copy link
Collaborator

Right now the disclaimer always mentions modules, even on pages for non-modules: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/sudo_become.html#ansible-builtin-sudo-substitute-user-do

Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs rendering LGTM!

@acozine
Copy link
Contributor

acozine commented Oct 19, 2021

This is a great improvement, thanks @felixfontein.

Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@felixfontein felixfontein merged commit f581897 into ansible-community:main Oct 20, 2021
@felixfontein felixfontein deleted the formulations branch October 20, 2021 14:06
@felixfontein
Copy link
Collaborator Author

@acozine @samccann @ariordan-redhat @briantist thanks for your comments and reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants