Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Python 3.8 for Ansible 5 #345

Merged
merged 4 commits into from
Dec 2, 2021

Conversation

felixfontein
Copy link
Collaborator

No description provided.

@dmsimard
Copy link
Contributor

dmsimard commented Dec 1, 2021

LGTM, will try it in a test build of 5.0.1.

@dmsimard
Copy link
Contributor

dmsimard commented Dec 1, 2021

@felixfontein works for me but if I may nitpick, there's some extra whitespace as a result:

    project_urls={
        'Bug Tracker': 'https://github.com/ansible/ansible/issues',
        'CI: Shippable': 'https://app.shippable.com/github/ansible/ansible',
        'Code of Conduct': 'https://docs.ansible.com/ansible/latest/community/code_of_conduct.html',
        'Documentation': 'https://docs.ansible.com/ansible/',
        'Mailing lists': 'https://docs.ansible.com/ansible/latest/community/communication.html#mailing-list-information',
        'Source Code': 'https://github.com/ansible/ansible',
    },
    license='GPLv3+',

    python_requires='>=3.8',

    packages=['ansible_collections'],
    include_package_data=True,
    install_requires=[
        'ansible-core>=2.12.0,<2.13',
    ],
    classifiers=[
        'Development Status :: 5 - Production/Stable',
        'Environment :: Console',
        'Framework :: Ansible',
        'Intended Audience :: Developers',
        'Intended Audience :: Information Technology',
        'Intended Audience :: System Administrators',
        'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',
        'Natural Language :: English',
        'Operating System :: POSIX',

        'Programming Language :: Python :: 3.8',
        'Programming Language :: Python :: 3.9',
        'Programming Language :: Python :: 3.10',
        'Topic :: System :: Installation/Setup',
        'Topic :: System :: Systems Administration',
        'Topic :: Utilities',
    ],

@dmsimard
Copy link
Contributor

dmsimard commented Dec 1, 2021

Also, unrelated but ouch: we should remove shippable from there.

@felixfontein
Copy link
Collaborator Author

The whitespace is something we can fix when we have more time. I've removed shippable, but we should discuss the other links as well - right now everything points to ansible/ansible. But that probably needs more discussion, and coordinaten with the core team.

Co-authored-by: David Moreau Simard <moi@dmsimard.com>
@felixfontein felixfontein merged commit b3ff183 into ansible-community:main Dec 2, 2021
@felixfontein felixfontein deleted the python-deps branch December 2, 2021 12:07
@felixfontein
Copy link
Collaborator Author

@dmsimard thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants