Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor I/O code; only write/copy files if the destination's content would change (assuming it is not too large) #374

Merged
merged 3 commits into from
Dec 25, 2021

Conversation

felixfontein
Copy link
Collaborator

The optimization ensures that if the Ansible docsite build is run twice in a row, Sphinx should be a lot faster on the second run since the input files do not change. (Or only some of them.)

I set the check limit to 256 KiB, which most RST files should be smaller than.

Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faster iteration and reduced run times, can't argue with that!

@felixfontein
Copy link
Collaborator Author

This implements a similar logic to the one in ansible/ansible#45062 (except that you can define a maximum size for when to do this comparison).

@felixfontein felixfontein merged commit b294d95 into ansible-community:main Dec 25, 2021
@felixfontein
Copy link
Collaborator Author

@briantist thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants