validate-tags: set default for the --ignore option and add tests #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gotmax23
commented
Apr 2, 2023
gotmax23
commented
- validate-tags: set default for the --ignore option
- add unit tests for validate-tags-file subcommand
When `--ignore` is not passed, the None default causes `Exception`s down the line when the code tries to iterate over it. Fixes: 015f935
The underlying codes relies on sets which apparently don't have consistent sort order across Pythons.
gotmax23
force-pushed
the
validate-tags-2
branch
from
8aa2fd3
to
00fff3e
Compare
felixfontein
approved these changes
Apr 3, 2023
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.