build-release: ensure Python files in the package compile #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks! This is definitely a good idea.
My main concern about this is how long it takes. But in CI, it only took ~15 seconds:
2023-11-10T20:43:16.9703084Z TASK [build-release : Run bytecompile] *****************************************
2023-11-10T20:43:16.9704440Z task path: /home/runner/work/antsibull/antsibull/antsibull/roles/build-release/tasks/test_bytecompile.yaml:19
2023-11-10T20:43:31.8439121Z changed: [localhost] =>
(in the Ansible 9 build). So I think this is totally fine.
gotmax23
force-pushed
the
release-compileall
branch
from
c3fe4cb
to
2762a0a
Compare
We've had multiple problems with certain collections pushing releases with broken Python files that don't compile. These issues break downstream packages even for users that don't need the broken plugins. This basic smoke test should help us prevent that type of issue.
gotmax23
force-pushed
the
release-compileall
branch
from
2762a0a
to
d04b291
Compare
felixfontein
approved these changes
Nov 11, 2023
|
Thanks! |
|
Thanks for adding this huge improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had multiple problems with certain collections pushing releases
with broken Python files that don't compile. These issues break
downstream packages even for users that don't need the broken plugins.
This basic smoke test should help us prevent that type of issue.