Figure out co-authors of each migrated collection from Git #497
Conversation
| return bool(author_entry) and not author_entry.endswith(forbidden_emails) | ||
|
|
||
|
|
||
| def find_all_the_authors(files, repo_path): |
There was a problem hiding this comment.
(this is kept for history, it's not actually called)
| commit_msg = '\n\n'.join( | ||
| ( | ||
| 'Initial commit', | ||
| 'See also: https://github.com/ansible-collections/overview', |
There was a problem hiding this comment.
@gundalow is this ref correct?
There was a problem hiding this comment.
I think that's a good URL, thanks.
|
@gundalow @jctanner @bcoca here's a collection from NWO that I published from a local run: coll-test/azure.azcollection@2e996dc. GitHub recognizes 87 co-authors in the commit! |
|
@webknjaz That's amazing work. |
|
The downside is that it makes the script considerably slower. Which is fine for a one-time run but still is annoying. So I don't know if @bcoca will accept it... |
|
I guess that's OK as long as this is one of the last PRs to be merged? |
|
@gundalow I think so. Looks like it adds ~30 min in CI but is faster for me locally. |
|
Migration is done, closing all open PRs and issues. |
This patch effectively extracts all authors and co-authors of files scheduled for removal per collection and adds them as
Co-Authored-By: Name <email>to the migrated collection initial commits. This implementation has some performance penalty, see the CI.