-
Notifications
You must be signed in to change notification settings - Fork 9
Should we have a collection linter? #15
Comments
Why not reusing the ansible-lint and extending it with the functionality we need? Yet-another-tool to maintain is a real nightmare I have, not joking. |
As I understand it, Many things from https://github.com/ansible-collections/overview/blob/main/collection_requirements.rst (Checklist: https://github.com/ansible-collections/overview/blob/main/collection_checklist.md) sound like a good fit for All in all I think a combination of |
@MarkusTeufelberger must have read the messaging from DevTools team. Yes, soon we will introduce To answer the original question: ansible-lint is the collection linter. If it does not do something, we will fix it. In fact linting collections is no1 use-case for the linter. To give some insights, in the future you will likely see more feature related to linting moving from ansible-test to ansible lint. Ansible-test will remain the too for unit/functional testing. As seen with molecule, the linting was deprecated and will be removed from it. We are slowly migrating towards a more unix like philosophy where we will have one tool for each scope: ansible-lint for static, ansible-test for unittest/module testing, molecule for integration testing. While not everything is set in stone, I do hope that this will help others makle the best future proof tool pick. |
@felixfontein Please close this issue if done, or open a new forum topic and then close the issue with a pointer to the new discussion: Community-topics: Archiving the repo |
Something that coexists with
ansible-test sanity
, and can check more conditions from https://github.com/ansible-collections/overview/blob/main/collection_requirements.rst, for example ansible/ansible#74558 (Error if non-standard dirs exist under plugins/).Advantage over having that (configurable in some way) in ansible-test: you don't need to use ignore.txt entries for older ansible-test versions if you are using a new plugin type that is introduced in a new ansible-core version; instead, just upgrade the linter.
Disadvantage: yet another tool to use, and someone has to write and maintain it.
The text was updated successfully, but these errors were encountered: