Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Deprecation of servicenow.servicenow in favor of servicenow.itsm #44

Closed
dmsimard opened this issue Sep 30, 2021 · 4 comments
Closed

Deprecation of servicenow.servicenow in favor of servicenow.itsm #44

dmsimard opened this issue Sep 30, 2021 · 4 comments
Assignees

Comments

@dmsimard
Copy link

dmsimard commented Sep 30, 2021

Summary

I have noticed that we currently carry servicenow.servicenow in the Ansible community package but it has been deprecated in favor of servicenow.itsm which is not in the package and has not yet filed for inclusion.

We should try to make sure this is addressed in time before the freeze for Ansible 5 with the appropriate redirects and deprecation messages as necessary.

@dmsimard dmsimard added the next_meeting Topics that needs to be discussed in the next Community Meeting label Sep 30, 2021
@tima
Copy link

tima commented Oct 6, 2021

I discussed this with @dmsimard offline but briefly stated for the record...

I recommend officially deprecating servicenow.servicenow and including servicenow.itsm in Ansible 5. I would not set up a mapping from one to the other -- these are different collections with different interfaces. The mapping won't work. I'd also recommend removing servicenow.servicenow in Ansible 6.

@dmsimard
Copy link
Author

dmsimard commented Oct 6, 2021

Hi @tima and thanks for chiming in.

We discussed this earlier at the community meeting: https://meetbot.fedoraproject.org/ansible-community/2021-10-06/ansible_community_meeting.2021-10-06-18.00.log.html#l-201

I recommend officially deprecating servicenow.servicenow and including servicenow.itsm in Ansible 5.

I was under the impression that servicenow.itsm did not plan to be included in the package though that may have been my misunderstanding.

Officially, it's not too late to ask to be included in Ansible 5 (until october 12th to apply) though it may not provide sufficient time to address potential concerns in time for the release.

If servicenow.itsm really wants to be included, they should apply here ASAP: https://github.com/ansible-collections/ansible-inclusion (see "discussions" tab).

I'd also recommend removing servicenow.servicenow in Ansible 6.

Keeping servicenow.servicenow in Ansible 5 and removing it in Ansible 6 is also what was suggested during the meeting.
I will open an issue in servicenow.servicenow to add proper deprecation notices in the modules (instead of just the readme) so the word can get out to a broader audience.

@tima
Copy link

tima commented Oct 6, 2021

On second thought if adding servicenow.itsm is going to cause a hassle, let’s hold on it for 5 and reassess for 6. I’m not sure what value there is in that collection for community distribution users.

I still recommend deprecating and eventually removing the other SNOW collection.

@mariolenz
Copy link
Contributor

I think we should close this issue because servicenow.servicenow has been removed from Ansible 7: ansible-community/ansible-build-data#156

In order to add servicenow.itsm, someone (the maintainers?) should create an inclusion request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants