Add ecosystem page #344
Add ecosystem page #344
Conversation
oraNod
force-pushed
the
ecosystem-page
branch
from
87c4be8
to
367bd42
Compare
|
Thanks for the review @samccann I've since updated this PR to add the documentation projects to the ecosystem. Could you please take a look at that? Is it too much? |
oraNod
force-pushed
the
ecosystem-page
branch
from
a74b42b
to
9100cb0
Compare
oraNod
force-pushed
the
ecosystem-page
branch
from
9100cb0
to
83279e9
Compare
|
Thanks again for the review @samccann I've rebased to remove the addition of the documentation projects. It would be better to create a separate PR for that as a follow up. |
| text: Find out how to use collections | ||
| contributor_guide: | ||
| link: "https://docs.ansible.com/ansible/devel/community/contributions_collections.html#collections-contributions" | ||
| text: Learn how to contribute to collections |
There was a problem hiding this comment.
This is a total nit, but this one and the one above (the text) - are anomalies on this page. Everything else is 'Foo documentation' etc, but these two are more action-oriented.
What about 'Collection user guide' and 'Collection contributor guide'?
I don't feel strongly about this so just tossing the idea out there and will marke the PR as approved.
There was a problem hiding this comment.
I see what you mean but this is a faithful reproduction of the current ecosystem page on the docsite. If we want to change that, I'd suggest a follow up PR.
There was a problem hiding this comment.
ok cool. I can do a followon pr once this merges.
| @@ -20,6 +20,7 @@ | |||
| @import "homepage-bullhorn-band"; | |||
| @import "homepage-events-band"; | |||
| @import "homepage-platform-band"; | |||
| @import "ecosystem"; | |||
There was a problem hiding this comment.
I want to get a bit more knowledgeable about the website so taking a moment to ask the goober question here - why have a separate style sheet just for the ecosystem page? Wouldn't it help to set the same style for anything that uses buttons like this for example so we know they all stay the same on sub pages like this?
There was a problem hiding this comment.
Separate style sheets give more granular control so you don't make a change on one page that inadvertently changes styling on another page. It is good to try and have central, reusable components and we do that for buttons on the homepage here: https://github.com/ansible-community/community-website/blob/main/themes/ansible-community/sass/_homepage-clickable.scss
In the case of the ecosystem page the buttons are different to the homepage. Notice that they are "inline-block" instead of "flex" (which is inherited on the homepage).
I guess there are some properties that we can inherit from the homepage buttons but that can get tricky really fast. So I thought it would just be more straightforward to leave the ecosystem page as a unique thing in case someone else down the line needs to make a change. There's not as much complexity and you need to focus on one page instead of multiple pages, even though it does result in more properties.
Should we need to create another secondary page with buttons, it's entirely feasible to break the button styling out into a shared scss definition. To my knowledge there are no plans for that so I didn't bother to keep things self-contained and straightforward.
This PR adds an ecosystem page that migrates content from https://docs.ansible.com/ecosystem.html