Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Remove setup.py file #109

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Remove setup.py file #109

merged 1 commit into from
Oct 26, 2021

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Oct 26, 2021

Modern python packaging no longer requires a setup.py. While we
kept it for compatibility reasons we no longer need it.

@tadeboro
Copy link

Is it possible to have editable installs when there is no setup.py file present? Last time I checked this was not possible (but I must admit it has been quite a while ago).

@ssbarnea
Copy link
Member Author

@tadeboro I use editable installs on all our repos, they are critical for my workflows. They fixed the editable installs about an year ago or something like this.

@ssbarnea ssbarnea added the enhancement This issue/PR relates to a feature request. label Oct 26, 2021
@ssbarnea ssbarnea changed the title Removed setup.py and adopt build Remove setup.py and adopt build Oct 26, 2021
@webknjaz
Copy link
Member

@tadeboro for as long as you're running the latest pip, you're good. They've special-cased setuptools for this to work. Meanwhile, there's also standardization work going on to make this possible across the ecosystem.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, drop the [aliases] section since nobody's using that for building dists anyway.

tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@webknjaz webknjaz changed the title Remove setup.py and adopt build Remove setup.py and adopt build Oct 26, 2021
Modern python packaging no longer requires a setup.py. While we
kept it for compatibility reasons we no longer need it.
@ssbarnea ssbarnea changed the title Remove setup.py and adopt build Remove setup.py file Oct 26, 2021
@ssbarnea ssbarnea merged commit acb7d4e into ansible-community:main Oct 26, 2021
@ssbarnea ssbarnea deleted the fix/pkg branch October 26, 2021 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants