This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
update goss version, fix ansible-lint warnings, add ability to copy defaults vars to goss vars #13
+25
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
reviewed
Jan 5, 2021
...s/cookiecutter/{{cookiecutter.molecule_directory}}/{{cookiecutter.scenario_name}}/verify.yml
Outdated
Show resolved
Hide resolved
abtreece
reviewed
Jan 9, 2021
There was a problem hiding this comment.
Hey @markwell-ch thanks for for the contribution!
I think this looks good from a functional perspective and I believe I understand the intention. Would you mind adding some detail to the description of the PR describing the intent? It will help to provide context for future contributions as well as documentation on how best to implement this plugin.
abtreece
approved these changes
Jan 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new variable
copy_defaults_varsset tofalse. If set totruethe content of the rolesdefaults/main.ymlare copied to the{{ goss_test_directory }}/varsfile on the remote and{{ goss_test_directory }}/varsis passed to goss with --vars. The vars defined indefaults/main.ymlcan then be referenced in the test definitions, see https://github.com/aelsabbahy/goss/blob/master/docs/manual.md#templates.