This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Add validate() implementation #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apatard
force-pushed
the
python_vagrant_1_0_0
branch
from
69d336a
to
3da33bc
Compare
python-vagrant 1.0.0 adds a new validate() function, so use it instead of the open coded version here. [ So, bump minimal version to 1.0.0 ]. While at it, add a small test case for it to make sure it's handled properly as I managed to get it wrong in my first version of this patch. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
apatard
force-pushed
the
python_vagrant_1_0_0
branch
from
188d4d8
to
23c49a1
Compare
ssbarnea
approved these changes
Apr 12, 2022
ssbarnea
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python-vagrant 1.0.0 adds a new validate() function, so use it
instead of the open coded version here. [ So, bump minimal version
to 1.0.0 ].
While at it, add a small test case for it to make sure it's handled
properly as I managed to get it wrong in my first version of this
patch.
Signed-off-by: Arnaud Patard apatard@hupstream.com