This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Avoid depending on molecule.config #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since molecule commit "Avoid parallel execution of a specific schenario" (65ccd6b), the molecule scenario directory is protected by a lock. Which is fine. Except that the vagrant module is using molecule.config.Config to get: - the molecule ephemeral directory, - path to the Vagrantfile. This will result in the vagrant module trying again to get the lock help by molecule and fails with messages like: Retrying to acquire lock on /home/zuul/.cache/molecule/scenarios/config_options, waiting for 30 seconds Retrying to acquire lock on /home/zuul/.cache/molecule/scenarios/config_options, waiting for 60 seconds Retrying to acquire lock on /home/zuul/.cache/molecule/scenarios/config_options, waiting for 90 seconds Retrying to acquire lock on /home/zuul/.cache/molecule/scenarios/config_options, waiting for 120 seconds Timedout trying to acquire lock on /home/zuul/.cache/molecule/scenarios/config_options As a solution, add a new parameter to the module, called 'workdir', used to set the vagrant working directory, which is in reality what's the path used by the module to store its files and this path is obviously the molecule ephemeral directory in case of molecule. So, if this parameter is not set, it will defaults to the molecule ephemeral directory. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
|
recheck |
1 similar comment
|
recheck |
ssbarnea
approved these changes
Oct 18, 2020
ssbarnea
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since molecule commit "Avoid parallel execution of a specific schenario"
(65ccd6b), the molecule scenario directory is protected by a lock.
Which is fine. Except that the vagrant module is using molecule.config.Config
to get:
This will result in the vagrant module trying again to get the lock help
by molecule and fails with messages like:
Retrying to acquire lock on /home/zuul/.cache/molecule/scenarios/config_options, waiting for 30 seconds
Retrying to acquire lock on /home/zuul/.cache/molecule/scenarios/config_options, waiting for 60 seconds
Retrying to acquire lock on /home/zuul/.cache/molecule/scenarios/config_options, waiting for 90 seconds
Retrying to acquire lock on /home/zuul/.cache/molecule/scenarios/config_options, waiting for 120 seconds
Timedout trying to acquire lock on /home/zuul/.cache/molecule/scenarios/config_options
As a solution, add a new parameter to the module, called 'workdir', used
to set the vagrant working directory, which is in reality what's the
path used by the module to store its files and this path is obviously
the molecule ephemeral directory in case of molecule.
So, if this parameter is not set, it will defaults to the molecule
ephemeral directory.
Fixes: #43
Signed-off-by: Arnaud Patard apatard@hupstream.com