Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker driver from core #2811

Merged
merged 1 commit into from Sep 1, 2020
Merged

Remove docker driver from core #2811

merged 1 commit into from Sep 1, 2020

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Sep 1, 2020

Docker driver will be a standalone project.

@ssbarnea ssbarnea added the major label Sep 1, 2020
@ssbarnea ssbarnea added this to the 3.1 milestone Sep 1, 2020
@ssbarnea ssbarnea merged commit 4efdb48 into master Sep 1, 2020
@ssbarnea ssbarnea deleted the feature/rm-ansible branch September 1, 2020 10:54
@geerlingguy
Copy link
Contributor

@ssbarnea This seems to be a rather huge change in functionality; is there anywhere this was discussed (the reasoning behind the change)? If this changes the default if unspecified, I know most of my own molecule configs will be broken and require changes.

@ssbarnea
Copy link
Member Author

ssbarnea commented Sep 1, 2020

Removal of drivers from core was initially planned for 3.0 but we postponed docker and podman due to lack of time.

Remember that this is not dropping support for them, is only part of moving them to individual projects with their own CI/CD pipelines. Read https://github.com/ansible-community/molecule/milestone/19 -- I will not release 3.1 before these drivers are functional, without changes for the users.

I suspect it will take some time to finish this move. If needed, I will create a stable/3.0 branch in order to make patches there.

@geerlingguy
Copy link
Contributor

@ssbarnea - The main thing that would need to be changed is you would have to install molecule with pip3 install molecule[docker] now, right? And make sure your molecule.yml defines driver.name: docker?

@PhilippSelenium
Copy link

This should really be more prominent in the documentation. Took me quite some time to find that my builds were broken because I was missing:

pip3 install molecule[docker]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants