Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Prerequisites for the test section #503

Merged
merged 4 commits into from Dec 11, 2020
Merged

Updated Prerequisites for the test section #503

merged 4 commits into from Dec 11, 2020

Conversation

MosheBlumbergX
Copy link
Member

Description

Updating pip install due to deprecation of docker driver

ansible/molecule#2811

Fixes #502

Type of change

  • updated Prerequisites, version depended

HOW_TO_TEST.md Outdated Show resolved Hide resolved
HOW_TO_TEST.md Outdated Show resolved Hide resolved
HOW_TO_TEST.md Show resolved Hide resolved
Copy link
Contributor

@JumaX JumaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MosheBlumbergX Thanks for the heads up, I've made some changes to clean up the wording. May still want to remove some extra white space as well. Additionally, can you rebase this to the 6.0.x branch? We don't commit directly into -post branches for stability reasons.

@MosheBlumbergX MosheBlumbergX changed the base branch from 6.0.1-post to 6.0.x December 11, 2020 13:38
Co-authored-by: Justin Manchester <justin@confluent.io>
@MosheBlumbergX
Copy link
Member Author

Thanks @JumaX, good catch on the branch and wording.

Copy link
Contributor

@JumaX JumaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@domenicbove domenicbove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@JumaX JumaX merged commit 580bcd8 into confluentinc:6.0.x Dec 11, 2020
@MosheBlumbergX MosheBlumbergX deleted the molecule-docker-moshe branch December 11, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker driver with new molecule version {'driver': [{'name': ['unallowed value docker']}]}
3 participants