Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of molecule filters #2872

Closed
ssbarnea opened this issue Oct 9, 2020 · 3 comments · Fixed by #2869
Closed

Removal of molecule filters #2872

ssbarnea opened this issue Oct 9, 2020 · 3 comments · Fixed by #2869
Assignees
@ssbarnea
Labels
bug

Comments

@ssbarnea
Copy link
Member

ssbarnea commented Oct 9, 2020 •
edited
Loading

Molecule ansible filters are moved are now moved to a standalone collection https://galaxy.ansible.com/community/molecule and we encourage plugin authors and test writers to either one of:

  • Replace molecule_to_yaml and molecule_from_yaml with their native ansible counterparts.
  • Use modules from community.molecule collection by using FQCN, like community.molecule.from_yaml. Remember to add community.molecule collection to your requirements.yaml and to install it.

As these filters were also present in user managed playbooks like create.yml and destroy.yml, we aim to make transition easier.

Because this is breaking change, it will only be included in 3.1.0.

Reasoning

The main reason behind this move is to finalize decoupling of molecule tool from ansible internals and removing the need to install Ansible python packages in the same python environment as molecule.

If done right, at the end molecule should only be a command line that calls ansible and that the testing playbooks could be run even without molecule itself.
@ssbarnea ssbarnea added the bug label Oct 9, 2020
@ssbarnea ssbarnea self-assigned this Oct 9, 2020
ssbarnea added a commit to ansible-community/molecule-vagrant that referenced this issue Oct 9, 2020
@ssbarnea
Remove molecule filters
5621dc1 
Removes molecule ansible filters.

Related: ansible/molecule#2872
ssbarnea added a commit to ansible-community/molecule-vagrant that referenced this issue Oct 9, 2020
@ssbarnea
Remove molecule filters
1a15785 
Removes molecule ansible filters.

Related: ansible/molecule#2872
@ssbarnea ssbarnea mentioned this issue Oct 9, 2020
Merged
ssbarnea added a commit that referenced this issue Oct 9, 2020
@ssbarnea
Remove molecule ansible filters
cddc1aa 
Molecule filters are now moved to their own project:
https://galaxy.ansible.com/community/molecule

Fixes: #2872
@ssbarnea ssbarnea changed the title Deprecation of molecule filters Removal of molecule filters Oct 10, 2020
@ssbarnea
Copy link
Member Author

@decentral1se @sshnaidm @cloudnull @geerlingguy @greg-hellings Please comment on this move as I want to minimize disruptions for current users and to assure that they have an easy migration path.

My concerns is that this will initially break most drivers, but I will assure a release is not made before I update most of them.

ssbarnea added a commit that referenced this issue Oct 10, 2020
@ssbarnea
Remove molecule ansible filters
9ff1e3b 
Molecule filters are now moved to their own project:
https://galaxy.ansible.com/community/molecule

Fixes: #2872
@ssbarnea ssbarnea mentioned this issue Oct 10, 2020
Merged
ssbarnea added a commit that referenced this issue Oct 10, 2020
@ssbarnea
Removed molecule ansible filters (#2869)
f81fd58 
Molecule filters are now moved to their own project:
https://galaxy.ansible.com/community/molecule

Fixes: #2872
ssbarnea added a commit to ansible-community/molecule-vagrant that referenced this issue Oct 10, 2020
@ssbarnea
Remove molecule filters (#52)
4b89a90 
Removes molecule ansible filters.

Related: ansible/molecule#2872
@decentral1se
Copy link
Contributor

Hey, missed this one but aware of it now, when the 3.1 release comes out, I'll let you know how it goes. Thanks.

@ssbarnea
Copy link
Member Author

I am still fixing bugs caused by move of docker and podman out of core. It could prove very useful o have someone brave enough to run molecule and main plugins from master branches.

@xoxys xoxys mentioned this issue Nov 7, 2020
Closed
serenabiodec added a commit to serenabiodec/molecule-ec2 that referenced this issue Nov 10, 2020
@serenabiodec
Working on ansible/molecule#2872
89b9178
ssbarnea pushed a commit to ansible-community/molecule-ec2 that referenced this issue Nov 27, 2020
@serenabiodec
Working on ansible/molecule#2872 (#31)
26f78a9
cfra added a commit to cfra/molecule-hetznercloud that referenced this issue Dec 4, 2020
@cfra
Remove molecule filters
8618e12 
Molecule ansible filters are not available by default anymore.

Related: ansible/molecule#2872
@cfra cfra mentioned this issue Dec 4, 2020
Closed
@nikParasyr nikParasyr mentioned this issue Dec 15, 2020
Closed
ssbarnea pushed a commit to ansible-community/molecule-openstack that referenced this issue Dec 15, 2020
@nikParasyr
Update create and destroy.yaml to use loop and remove molecule filters (
37f4d60 
#19)

* Use loop instead of with_items

Convert the usage of with_items to loops based
on docs: https://docs.ansible.com/ansible/latest/user_guide/playbooks_loops.html#with-items

* Remove molecule filters

Molecule ansible filters are not available by default anymore.
Related: ansible/molecule#2872
openstack-mirroring pushed a commit to openstack/kayobe that referenced this issue Mar 25, 2021
@mnasiadka
Bump max Ansible version to 2.10
16cce92 
Molecule also needs to be bumped to support Ansible 2.10
lint: section changed in Molecule 3.x - adapted.
molecule-docker added do test-reqs because it code has moved to it from
molecule core
pytest-testinfra and pytest-molecule needed for testinfra tests to work

[1]: ansible/molecule#2872

Change-Id: I0299f5126ebd080f3912a76294b0013abe7747a0
openstack-mirroring pushed a commit to openstack/openstack that referenced this issue Mar 25, 2021
@openstack-gerrit
Update git submodules
eeb3c61 
* Update kayobe from branch 'master'
  to 0e2efc09ecea8f87209dd1bf0456f313af83610e
  - Merge "Bump max Ansible version to 2.10"
  - Bump max Ansible version to 2.10
    
    Molecule also needs to be bumped to support Ansible 2.10
    lint: section changed in Molecule 3.x - adapted.
    molecule-docker added do test-reqs because it code has moved to it from
    molecule core
    pytest-testinfra and pytest-molecule needed for testinfra tests to work
    
    [1]: ansible/molecule#2872
    
    Change-Id: I0299f5126ebd080f3912a76294b0013abe7747a0
@grumpy-penguin grumpy-penguin mentioned this issue Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssbarnea ssbarnea

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed molecule ansible filters ansible/molecule
2 participants
@ssbarnea @decentral1se