Document description for action arguments (verify and side_effect) #3605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarao
requested review from
Shaps,
jseguillon,
ssbarnea,
ganeshrn and
priyamsahoo
and removed request for
a team
ziegenberg
suggested changes
Jun 22, 2022
There was a problem hiding this comment.
Hi @amarao!
Thank you very much for your contribution; it's much appreciated!
I applied the labels, so now only one more CI check is red. Can you fix this? Also, some minor suggestions for grammar improvements.
amarao
force-pushed
the
update_docs_for_multiple_side_effects
branch
2 times, most recently
from
c36f962
to
a2068bb
Compare
amarao
force-pushed
the
update_docs_for_multiple_side_effects
branch
from
a2068bb
to
4ed7900
Compare
amarao
force-pushed
the
update_docs_for_multiple_side_effects
branch
from
4ed7900
to
7d5d2c2
Compare
|
@ziegenberg Thank you a lot for suggestions. (I don't have GH permissions to 'Commit suggestions', so I applied them manually). I believe I fixed |
ziegenberg
approved these changes
Jun 22, 2022
|
Looks good now! |
ziegenberg
reviewed
Jun 22, 2022
ziegenberg
suggested changes
Jun 22, 2022
amarao
force-pushed
the
update_docs_for_multiple_side_effects
branch
from
adba929
to
487c982
Compare
ziegenberg
approved these changes
Jun 23, 2022
ssbarnea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding docs for action arguments.
Should fix #3591
I'm not familiar with syntax and hope it's done right.