Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add podman functional tests (#2159) #2323

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Add podman functional tests (#2159) #2323

merged 1 commit into from
Oct 24, 2019

Conversation

sshnaidm
Copy link
Contributor

Signed-off-by: Sagi Shnaidman sshnaidm@redhat.com

Add functional tests for podman driver

PR Type

  • Feature Pull Request

@sshnaidm sshnaidm force-pushed the testpodman branch 3 times, most recently from 6432900 to 454700a Compare September 23, 2019 08:46
@decentral1se
Copy link
Contributor

Hey @sshnaidm, thanks for this. I mentioned a comment in the IRC and also on #2317 (comment) regarding our plans for the drivers. I suppose the best course of action is to get this PR passing soon and merge it OR close the PR and follow the path of removing the driver code (see #2303) and then create a repostiory in a similar fashion to https://github.com/pycontribs/molecule-inspec. This is all a bit experimental right now but that's the current state. Let me know what you think.

@ssbarnea
Copy link
Member

@sshnaidm please fix this, we need better podman coverage now more than ever, especially as we do not have docker on centos8 and rhel8.

@sshnaidm
Copy link
Contributor Author

The problem is that podman driver will work only with patch ansible/ansible#57741 in ansible and this will be only in 2.9. I've created backport in ansible/ansible#62915 but not sure if it will be merged.
So far we need to limit tests to run on ansible 2.9 minimum.

@ssbarnea
Copy link
Member

@sshnaidm I can try to add a fixture that enables tests only on specific ansible versions. Would this help you?

@ssbarnea
Copy link
Member

This should help you #2337

@sshnaidm
Copy link
Contributor Author

Seems like failed tests are hetznercloud tests, not related to podman. And all podman tests are skipped, because it can't be installed on ubuntu. Need to test it on centos.

@sshnaidm sshnaidm force-pushed the testpodman branch 4 times, most recently from 6c09c66 to a29847a Compare September 28, 2019 12:18
@decentral1se
Copy link
Contributor

Restarted the build 👍

@sshnaidm
Copy link
Contributor Author

As I see podman tests are skipped, although podman is installed in last version and ansible version is 2.9rc01. I don't understand why it's still skipped: https://travis-ci.com/ansible/molecule/jobs/240039472
@ssbarnea @decentral1se any thoughts?

@sshnaidm
Copy link
Contributor Author

OK, I think I found what is the problem. Current ansible 2.9 has version 2.9rc01 and pkg_resources compares it incorrectly:

pkg_resources.parse_version("2.9rc01") >= pkg_resources.parse_version("2.9")
False

I've changed minimum version to 2.8.999 to avoid this.
@ssbarnea ^^

@sshnaidm
Copy link
Contributor Author

sshnaidm commented Oct 1, 2019

OK, now podman runs finally, and fails. Will check what is the reason.

@sshnaidm sshnaidm force-pushed the testpodman branch 2 times, most recently from b0ce903 to 54d3d3d Compare October 1, 2019 19:04
@sshnaidm sshnaidm force-pushed the testpodman branch 2 times, most recently from a893653 to e9e94dd Compare October 22, 2019 19:13
@sshnaidm sshnaidm changed the title WIP: Add podman functional tests (#2159) Add podman functional tests (#2159) Oct 22, 2019
@sshnaidm sshnaidm force-pushed the testpodman branch 2 times, most recently from 2837dc5 to 7e8ae66 Compare October 22, 2019 21:34
@sshnaidm sshnaidm force-pushed the testpodman branch 2 times, most recently from d14c124 to 8be68bf Compare October 23, 2019 08:55
ssbarnea
ssbarnea requested changes Oct 23, 2019
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor bits, also please mention in the PR message how to test locally podman, to make it easier for others to test it locally.

I am looking forward to get this merged today!

....role_name}}/{{cookiecutter.molecule_directory}}/{{cookiecutter.scenario_name}}/molecule.yml Outdated Show resolved Hide resolved
molecule/test/functional/conftest.py Show resolved Hide resolved
molecule/test/resources/playbooks/podman/Dockerfile.j2 Show resolved Hide resolved
@fabianvf
Copy link
Contributor

@sshnaidm I can help with the requested changes if you're running low on free cycles

@sshnaidm
Copy link
Contributor Author

@fabianvf thanks, I think we're good now. Waiting for #2394 to merge, and then it should be ok.

@sshnaidm
Add podman functional tests
78620c4 
Run podman tests for molecule podman driver
Closes ansible#2159
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
@ssbarnea ssbarnea merged commit 76858f2 into ansible:master Oct 24, 2019
@ssbarnea ssbarnea added test Improvement to quality assurance: CI/CD, testing, building podman and removed hacktoberfest labels Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@decentral1se decentral1se Awaiting requested review from decentral1se

Assignees

@sshnaidm sshnaidm

Labels
test Improvement to quality assurance: CI/CD, testing, building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sshnaidm @decentral1se @ssbarnea @fabianvf