Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored molecule linting #2513

Merged
merged 1 commit into from Feb 4, 2020
Merged

Refactored molecule linting #2513

merged 1 commit into from Feb 4, 2020

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Jan 26, 2020 •
edited

Changes configuration of linting to a model that does not require
writing plugins in order to support other linters.

Mainly the new setup executes a shell command as part of the lint sequence step.

When no command is mentioned, linting will be skipped.

  • only one place to configure linting in molecule
  • user decides what commands to run (more flexible)
  • molecule no longer have knowledge of specific linters

More details regarding for this breaking change can be found on linked ticket.

Fixes: #2293

@ssbarnea ssbarnea changed the title WIP: Removed provisioner and verifier specific linting support Refactored molecule linting Jan 28, 2020
@ssbarnea ssbarnea added the major label Jan 28, 2020
@ssbarnea ssbarnea self-assigned this Jan 28, 2020
@ssbarnea ssbarnea mentioned this pull request Jan 28, 2020
Closed
@ssbarnea ssbarnea force-pushed the fix/delinting branch 6 times, most recently from 68cc2d6 to c0fc6e9 Compare February 1, 2020 18:16
@ssbarnea ssbarnea mentioned this pull request Feb 1, 2020
Closed
@ssbarnea ssbarnea marked this pull request as ready for review February 1, 2020 20:43
@ssbarnea ssbarnea added this to the 3.0 milestone Feb 1, 2020
@ansible ansible deleted a comment from ansible-zuul bot Feb 1, 2020
@ansible ansible deleted a comment from ansible-zuul bot Feb 1, 2020
@ansible ansible deleted a comment from ansible-zuul bot Feb 1, 2020
@ansible ansible deleted a comment from ansible-zuul bot Feb 1, 2020
@ansible ansible deleted a comment from ansible-zuul bot Feb 1, 2020
@ansible ansible deleted a comment from ansible-zuul bot Feb 1, 2020
@ansible ansible deleted a comment from ansible-zuul bot Feb 1, 2020
sshnaidm
sshnaidm reviewed Feb 1, 2020
View reviewed changes
molecule/test/functional/docker/test_scenarios.py Outdated Show resolved Hide resolved
docs/configuration.rst Show resolved Hide resolved
zuul.d/layout.yaml Outdated Show resolved Hide resolved
docs/getting-started.rst Outdated Show resolved Hide resolved
molecule/command/lint.py Show resolved Hide resolved
molecule/command/lint.py Outdated Show resolved Hide resolved
@ssbarnea ssbarnea force-pushed the fix/delinting branch 4 times, most recently from 3f6fe4d to a13d1b4 Compare February 3, 2020 15:14
@ansible ansible deleted a comment from ansible-zuul bot Feb 3, 2020
@ssbarnea ssbarnea added the .bump label Feb 3, 2020
@ansible ansible deleted a comment from ansible-zuul bot Feb 3, 2020
@ansible ansible deleted a comment from ansible-zuul bot Feb 3, 2020
@ansible ansible deleted a comment from ansible-zuul bot Feb 3, 2020
dmsimard
dmsimard reviewed Feb 3, 2020
View reviewed changes
molecule/command/lint.py Outdated Show resolved Hide resolved
@ssbarnea ssbarnea added the gate label Feb 3, 2020
@ansible-zuul
Copy link
Contributor

ansible-zuul bot commented Feb 4, 2020

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@ssbarnea
Lint command refactored for molecule v3
79451c1 
* breaking change due lint command rewrite ansible#2293.
* adopts schema v3, drops old ones

Fixes: ansible#2293
@ansible-zuul ansible-zuul bot removed the gate label Feb 4, 2020
@ansible ansible deleted a comment from ansible-zuul bot Feb 4, 2020
@ansible ansible deleted a comment from ansible-zuul bot Feb 4, 2020
@ssbarnea ssbarnea added the gate label Feb 4, 2020
@ansible-zuul
Copy link
Contributor

ansible-zuul bot commented Feb 4, 2020

Build succeeded.

@ansible-zuul
Copy link
Contributor

ansible-zuul bot commented Feb 4, 2020

Build succeeded (gate pipeline).

@ansible-zuul ansible-zuul bot merged commit a3ff4cd into ansible:master Feb 4, 2020
@ssbarnea ssbarnea deleted the fix/delinting branch September 7, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudnull cloudnull Awaiting requested review from cloudnull

@LukeShortCloud LukeShortCloud Awaiting requested review from LukeShortCloud

@geerlingguy geerlingguy Awaiting requested review from geerlingguy

@sshnaidm sshnaidm Awaiting requested review from sshnaidm

@dmsimard dmsimard Awaiting requested review from dmsimard

Assignees

@ssbarnea ssbarnea

Labels
major
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Externalize linting from molecule v3
3 participants
@ssbarnea @dmsimard @sshnaidm