WIP: Refactored molecule linting #2447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
fix/lint-as-cmd
branch
from
f936c6c
to
13df8aa
Compare
This was referenced Nov 28, 2019
ssbarnea
force-pushed
the
fix/lint-as-cmd
branch
4 times, most recently
from
601d773
to
469923c
Compare
richardskumat
added a commit
to richardskumat/dind-ansible-molecule
that referenced
this pull request
Nov 29, 2019
for the time being due to molecule v3 likely to break my current ansible role tests as per proposed in: https://old.reddit.com/r/ansible/comments/e1wq19/proposal_on_ansible_molecule_v3_major_linting/ ansible/molecule#2293 ansible/molecule#2447
ssbarnea
force-pushed
the
fix/lint-as-cmd
branch
from
469923c
to
1381c04
Compare
ssbarnea
force-pushed
the
fix/lint-as-cmd
branch
from
1381c04
to
bba52ec
Compare
Changes configuration of linting to a model that does not require writing plugins in order to support other linters. Mainly the new setup executes an Ansible shell task as part of the the lint step. * only one place to configure linting in molecule * user decides what commands to run (more flexible) * molecule no longer have knowledge of specific linters Fixes: ansible#2293
ssbarnea
force-pushed
the
fix/lint-as-cmd
branch
from
bba52ec
to
5855f85
Compare
|
Work is done now inside #2513 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO-NOT-REVIEW WORK IN PROGRESS
Changes configuration of linting to a model that does not require
writing plugins in order to support other linters. Mainly the new
setup executes an Ansible shell task as part of the the lint step.
Fixes: #2293