Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklisted module names should be lowercase #62

Closed
danbarr opened this issue Nov 16, 2021 · 3 comments
Closed

Blacklisted module names should be lowercase #62

danbarr opened this issue Nov 16, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@danbarr
Copy link
Contributor

danbarr commented Nov 16, 2021

Describe the Issue
The ATM, CAN, SCTP, and TIPC kernel module blacklist entries are entered into /etc/modprobe.d/blacklist.conf in uppercase, causing SCAP scan to fail on RHEL-08-040021, RHEL-08-040022, RHEL-08-040023, RHEL-08-040024.

Expected Behavior
Module names in /etc/modprobe.d/blacklist.conf should be in lowercase.

Actual Behavior
SCAP scan fails on these four controls because it's looking for the module names atm, can, sctp, and tipc in lowercase.

Control(s) Affected
RHEL-08-040021
RHEL-08-040022
RHEL-08-040023
RHEL-08-040024

Environment (please complete the following information):

  • Ansible Version: 2.9.27
  • Host Python Version: 3.6.8
  • Role version: 2.3.0

Possible Solution
Will submit a PR

@danbarr danbarr added the bug Something isn't working label Nov 16, 2021
@uk-bolly uk-bolly self-assigned this Dec 13, 2021
@uk-bolly
Copy link
Member

Hi @danbarr

Thank you again for taking the time to highlight issue so that we may continually improve this role. While the stig is followed to the letter, we are agreeing that this is the case and this should be lower case.
We are looking at a new release and will be sure to add this solution into the new release.

Thanks as always for your time.

uk-bolly

uk-bolly added a commit that referenced this issue Dec 22, 2021
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly uk-bolly mentioned this issue Dec 23, 2021
@uk-bolly
Copy link
Member

Hi @danbarr

These should now be in place in the latest devel release (which is also a stig update(where they have also changed the documentation to be lowercase)).
I will close this issue in the next week unless you have any questions?

Thanks as always for you feedback and support.

uk-bolly

@danbarr
Copy link
Contributor Author

danbarr commented Dec 29, 2021

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants