Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SSSD Control Conditions #172

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

JacobBuskirk
Copy link
Contributor

Overall Review of Changes:
Moved sssd control conditions so that they are always the first condition. If all sssd controls are disabled, it will now work instead of throwing an error.

Issue Fixes:
#162

Enhancements:
N/A

How has this been tested?:
I have tested running this against RHEL 8 servers

Signed-off-by: Jacob Buskirk <jbuskirk1995@gmail.com>
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MrSteve81 MrSteve81 self-assigned this Feb 16, 2023
@MrSteve81 MrSteve81 self-requested a review February 16, 2023 17:53
@MrSteve81 MrSteve81 removed their assignment Feb 16, 2023
Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Look Good.

@georgenalen georgenalen merged commit f2760dc into ansible-lockdown:devel Feb 16, 2023
@JacobBuskirk JacobBuskirk deleted the SSSD branch February 22, 2023 18:56
@uk-bolly uk-bolly linked an issue Mar 3, 2023 that may be closed by this pull request
This was referenced Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSSD controls fail when all SSSD controls are disabled
3 participants