Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container updates & issue 204 #205

Merged
merged 6 commits into from
May 30, 2023
Merged

Container updates & issue 204 #205

merged 6 commits into from
May 30, 2023

Conversation

uk-bolly
Copy link
Member

@uk-bolly uk-bolly commented May 25, 2023

Overall Review of Changes:
Tidy up and alignment if system_is_container.

  • moved priority of the check
  • updated container vars
  • tidy up of controls now included in vars so control via centralised vars than conditional statements

Issue Fixes:
#204
thanks to Maheshlagisetti on discord community

Enhancements:
Part of #204 tidy up and fqcn of prelim steps

How has this been tested?:
Manually

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly uk-bolly requested a review from MrSteve81 May 25, 2023 08:27
MrSteve81
MrSteve81 previously approved these changes May 25, 2023
Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@MrSteve81 MrSteve81 merged commit 27c2a31 into devel May 30, 2023
3 checks passed
@uk-bolly uk-bolly deleted the container_updates branch June 28, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants