Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meet fix text of V-244546 #266

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

fallenpixel
Copy link
Contributor

Overall Review of Changes:
The default deny policy discussed in the STIG fix text references deny perm=any all : all instead of deny all all as is set as the default of this.

Issue Fixes:
#265

Enhancements:

How has this been tested?:
Providing a variable setting rhel8stig_fapolicy_white_list to this value still functions correctly. Just interested in updating the default.

Signed-off-by: Eric Lehmann <katyl@katyl.info>
Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find and update

@uk-bolly uk-bolly merged commit 51943d7 into ansible-lockdown:devel Apr 11, 2024
4 checks passed
@fallenpixel fallenpixel deleted the v-244546 branch April 11, 2024 18:14
uk-bolly added a commit that referenced this pull request Apr 29, 2024
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly uk-bolly mentioned this pull request Apr 29, 2024
uk-bolly added a commit that referenced this pull request Apr 30, 2024
* updated v1r13 reference

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* v1r13 updates

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updated thanks to @Phenix66

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updated thanks to @fallenpixel

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* tidy up quotes around mode

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* tidy up variables

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updates to auditing order

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* #266 fix added

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* added prelim to includes

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updated v1r13 reference

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* v1r13 updates

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updated thanks to @Phenix66

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* tidy up quotes around mode

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* tidy up variables

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updates to auditing order

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* added prelim to includes

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* file mode updates with improved var usage

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

---------

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
uk-bolly added a commit that referenced this pull request May 24, 2024
* updated v1r13 reference

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* v1r13 updates

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updated thanks to @Phenix66

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updated thanks to @fallenpixel

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* tidy up quotes around mode

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* tidy up variables

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updates to auditing order

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* #266 fix added

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* added prelim to includes

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updated v1r13 reference

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* v1r13 updates

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updated thanks to @Phenix66

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* tidy up quotes around mode

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* tidy up variables

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* updates to auditing order

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* added prelim to includes

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

* file mode updates with improved var usage

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

---------

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants