Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.15 Should install/uninstall MTAs appropriately #48

Closed
goniomdq opened this issue Jul 20, 2021 · 2 comments
Closed

2.1.15 Should install/uninstall MTAs appropriately #48

goniomdq opened this issue Jul 20, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@goniomdq
Copy link

This task should install/uninstall the MTAs as required.

goniomdq pushed a commit to goniomdq/UBUNTU18-CIS-1 that referenced this issue Jul 21, 2021
Signed-off-by: Jose Gonzalez Goni <joseg@datacom.co.nz>
@georgenalen
Copy link
Contributor

@goniomdq,
Thanks for raising this issue and submitting a PR. I think I am going to adjust that control a bit differently though. I am going to add a prelim task to capture all installed packages and if postfix or exim are installed it will adjust the configs appropriately based on that finding, no longer via a manually entered var in defaults/main.yml.

Since the control itself doesn't say to install or remove the MTA's I don't think this control should be either. With the way I am going to adjust it, this control will be skipped if either exim or postfix are not installed, which is still in compliance with control 2.1.15. Also if for some reason both are installed it will be bring both instances into compliance for this control, which also will be in compliance.

With these changes I will bring both config edits back into the same task since the format should be one task per control, even if that task contains a single or multiple blocks within it.

The plan is to merge your edits into a staging branch for me adjust 2.1.15 before merging into devel, which will keep you on the contributors for the other additions you have made.

Thanks again for raising issues and contributing to the project. These do really help the product become better.

George

@georgenalen georgenalen added the enhancement New feature or request label Jul 21, 2021
@georgenalen georgenalen self-assigned this Jul 21, 2021
georgenalen added a commit that referenced this issue Aug 31, 2021
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
@georgenalen
Copy link
Contributor

Addressed in release 1.3.1

uk-bolly pushed a commit that referenced this issue Sep 20, 2023
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants