Fix/cis 5 2 4 5 loop #124
Merged
Fix/cis 5 2 4 5 loop #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
Signed-off-by: Alexandre Rousseau <arousseau@coveo.com>
Signed-off-by: Alexandre Rousseau <arousseau@coveo.com>
Signed-off-by: Alexandre Rousseau <arousseau@coveo.com>
arousseau-coveo
force-pushed
the
fix/cis-5-2-4-5-loop
branch
from
9fbdd14
to
a3df7a1
Compare
MrSteve81
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Added a default value when
ubtu20cis_rule_5_2_4_5is skippedIssue Fixes:
Since
ubtu20cis_rule_5_2_4_5relies on a prelim register when it's skip the register doesn't populate the value of:auditd_conf_fileswhich will results in the following error ifubtu20cis_rule_5_2_4_5is skipped.This is a known behaviour of ansible since even if the when condition is not met the loop operation will be computed.
Enhancements:
Please list any enhancements/features that are not open issue tickets
How has this been tested?:
Please give an overview of how these changes were tested. If they were not please use N/A
I run the breaking ansible pass with
ubtu20cis_rule_5_2_4_5set to false and it did throw any error.