2024 April Update: Section 1.2.x Logic, Section 19 HKU Improvement, Handler Fixes, Prelim Fixes #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
Signed-off-by: Frederick Witty <frederickw@mindpointgroup.com>
mfortin
reviewed
Apr 4, 2024
| @@ -26,7 +26,7 @@ | |||
| # Current list is elastic and will be updated as we test more cloud based services. | |||
| # Current testing is working in Azure using Hyper-V. We are currently using this for reference: | |||
| # https://github.com/ansible/ansible/blob/905131fc76a07cf89dbc8d33e7a4910da3f10a16/lib/ansible/module_utils/facts/virtual/linux.py#L205 | |||
| - name: Set Fact If Cloud-Based System. | |||
| - name: PRELIM | Set Fact If Cloud-Based System. | |||
| ansible.builtin.set_fact: | |||
| win19cis_cloud_based_system: true | |||
| when: | |||
There was a problem hiding this comment.
wouldn't the Azure fix be here ?
mfortin
reviewed
Apr 4, 2024
| @@ -26,7 +26,7 @@ | |||
| # Current list is elastic and will be updated as we test more cloud based services. | |||
| # Current testing is working in Azure using Hyper-V. We are currently using this for reference: | |||
| # https://github.com/ansible/ansible/blob/905131fc76a07cf89dbc8d33e7a4910da3f10a16/lib/ansible/module_utils/facts/virtual/linux.py#L205 | |||
| - name: Set Fact If Cloud-Based System. | |||
| - name: PRELIM | Set Fact If Cloud-Based System. | |||
| ansible.builtin.set_fact: | |||
| win19cis_cloud_based_system: true | |||
| when: | |||
There was a problem hiding this comment.
Suggested change
| when: | |
| when: | |
| - ansible_system_vendor == 'Microsoft Corporation' |
|
Thank you @georgenalen ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Thank you @MrSteve81 for the enhancements to this release!
Issue Fixes:
Azure Cloud Logic for 1.2.x Section from @mfortin
Enhancements:
Improved Reboot Handler and SID user Logic for all local accounts
How has this been tested?:
Locally and Azure